OPTIM: Only remove a task from the loading dictionary if it actually failed. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…failed. If it was just cancelled, let the task run otherwise it could just timeout again the next time.
…ing, as it will have either been removed by another thread, or will be cleaned up on the next call.
Unit Tests - Ubuntu_Any_CPU_Debug42 tests ±0 42 ✅ ±0 12s ⏱️ +11s Results for commit bb91eae. ± Comparison against base commit 4d7bbd2. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Unit Tests - Ubuntu_Any_CPU_Release42 tests ±0 42 ✅ ±0 13s ⏱️ +12s Results for commit bb91eae. ± Comparison against base commit 4d7bbd2. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Unit Tests - Windows_Any_CPU_Release42 tests ±0 42 ✅ ±0 13s ⏱️ +10s Results for commit bb91eae. ± Comparison against base commit 4d7bbd2. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Unit Tests - Windows_Any_CPU_Debug42 tests ±0 42 ✅ ±0 13s ⏱️ +11s Results for commit bb91eae. ± Comparison against base commit 4d7bbd2. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it was just cancelled, let the task run otherwise it could just timeout again the next time.