-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade sqlalchemy to 2.0.27 and updated test cases #3805
feat: upgrade sqlalchemy to 2.0.27 and updated test cases #3805
Conversation
SDK Test Report101 files ±0 101 suites ±0 2m 15s ⏱️ +7s Results for commit 7ea6d1e. ± Comparison against base commit db1c1f8. This pull request removes 48 and adds 29 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Linux Test Report 53 files ±0 60 suites ±0 28m 2s ⏱️ +11s For more details on these failures, see this check. Results for commit 7ea6d1e. ± Comparison against base commit db1c1f8. ♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3805 +/- ##
=============================================
- Coverage 74.93% 40.75% -34.18%
Complexity 658 658
=============================================
Files 738 195 -543
Lines 133155 11655 -121500
Branches 1380 1379 -1
=============================================
- Hits 99779 4750 -95029
+ Misses 33072 6601 -26471
Partials 304 304 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The error content of cicd is not caused by the current PR commit. Now apply for manual merge. |
The error content of cicd is not caused by the current PR commit. Now apply for manual merge. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
Support SQLAlchemy 2.x for Python SDK #1281
The current version of SQLAlchemy being used is 1.4.50, which supports relatively older versions.
What is the new behavior (if this is a feature change)?
Upgrade SQLAlchemy to 2.0.27 and updated relevant test cases.
Testing has confirmed that dbapi.py is compatible with both SQLAlchemy 1.4 and 2.0 versions, allowing users to adjust compilation as needed.