Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config to delete logs automatically #3706

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jan 16, 2024

glog has been upgraded to v0.6.0 in #3704
close #2956

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jan 16, 2024
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Feb 22, 2024

SDK Test Report

101 files  101 suites   2m 13s ⏱️
345 tests 331 ✅ 14 💤 0 ❌
471 runs  457 ✅ 14 💤 0 ❌

Results for commit 4d291e7.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.90%. Comparing base (a8d7a1d) to head (4d291e7).

Files Patch % Lines
src/base/glog_wrapper.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3706      +/-   ##
============================================
+ Coverage     74.88%   74.90%   +0.01%     
  Complexity      658      658              
============================================
  Files           737      737              
  Lines        132521   132523       +2     
  Branches       1378     1378              
============================================
+ Hits          99240    99268      +28     
+ Misses        32977    32951      -26     
  Partials        304      304              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 22, 2024

Linux Test Report

    57 files     244 suites   1h 16m 7s ⏱️
12 583 tests 12 576 ✅ 7 💤 0 ❌
17 840 runs  17 833 ✅ 7 💤 0 ❌

Results for commit 4d291e7.

♻️ This comment has been updated with latest results.

@dl239 dl239 enabled auto-merge (squash) February 26, 2024 05:50
@dl239 dl239 merged commit 76af71c into 4paradigm:main Feb 26, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete old log files automatically
3 participants