Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(java): upgrade scala to 2.12.15 #3623

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

aceforeverd
Copy link
Collaborator

I'd like upgrade scala so it can run metals as LSP server.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25a24dc) 74.97% compared to head (8bcc318) 74.97%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3623      +/-   ##
============================================
- Coverage     74.97%   74.97%   -0.01%     
  Complexity      640      640              
============================================
  Files           724      724              
  Lines        130359   130359              
  Branches       1318     1318              
============================================
- Hits          97742    97740       -2     
- Misses        32324    32326       +2     
  Partials        293      293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metals support scala >= 2.12.11
@aceforeverd aceforeverd changed the title build(java): upgrade scala to 2.12.18 build(java): upgrade scala to 2.12.15 Nov 24, 2023
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd enabled auto-merge (squash) November 24, 2023 08:04
@aceforeverd aceforeverd merged commit 08b1918 into 4paradigm:main Nov 30, 2023
21 of 22 checks passed
@aceforeverd aceforeverd deleted the build-upgrade-scala branch November 30, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants