Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize the error message of create table #3434

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Aug 9, 2023

close #3431

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 76.97% and project coverage change: -3.37% ⚠️

Comparison is base (5343823) 78.73% compared to head (585de7d) 75.37%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3434      +/-   ##
============================================
- Coverage     78.73%   75.37%   -3.37%     
- Complexity        0      414     +414     
============================================
  Files           545      706     +161     
  Lines        118815   128371    +9556     
  Branches          0     1206    +1206     
============================================
+ Hits          93547    96756    +3209     
- Misses        25252    31374    +6122     
- Partials         16      241     +225     
Files Changed Coverage Δ
src/nameserver/name_server_impl.h 100.00% <ø> (ø)
src/test/util.h 55.55% <ø> (ø)
src/sdk/node_adapter.cc 57.45% <5.55%> (-0.15%) ⬇️
src/schema/index_util.cc 77.22% <62.50%> (-0.56%) ⬇️
src/nameserver/name_server_impl.cc 44.94% <66.66%> (+0.18%) ⬆️
src/client/tablet_client.cc 57.74% <71.42%> (-1.13%) ⬇️
src/test/util.cc 86.43% <96.00%> (+1.37%) ⬆️
src/catalog/distribute_iterator_test.cc 100.00% <100.00%> (ø)
src/replica/binlog_test.cc 93.65% <100.00%> (+0.10%) ⬆️
src/replica/snapshot_replica_test.cc 91.61% <100.00%> (+0.05%) ⬆️

... and 177 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dl239 dl239 changed the title refact: optimize the error message of create table refactor: optimize the error message of create table Aug 9, 2023
@dl239 dl239 merged commit a013ba3 into 4paradigm:main Aug 31, 2023
@dl239 dl239 deleted the feat/create_table branch August 31, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize the error message of create table
3 participants