Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run addindex failed #3393

Merged
merged 11 commits into from
Aug 31, 2023
Merged

fix: run addindex failed #3393

merged 11 commits into from
Aug 31, 2023

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jul 24, 2023

CREATE INDEX will launch an async task. another CREATE INDEX cmd with the same table fails if the previous task did not complete
close #3399

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 48.14% and project coverage change: +38.44% 🎉

Comparison is base (d5647d1) 37.25% compared to head (f914298) 75.69%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3393       +/-   ##
=============================================
+ Coverage     37.25%   75.69%   +38.44%     
  Complexity      414      414               
=============================================
  Files           177      701      +524     
  Lines         10294   126722   +116428     
  Branches       1206     1206               
=============================================
+ Hits           3835    95927    +92092     
- Misses         6218    30554    +24336     
  Partials        241      241               
Files Changed Coverage Δ
src/base/status.h 100.00% <ø> (ø)
src/nameserver/name_server_impl.h 100.00% <ø> (ø)
src/sdk/sql_cluster_router.cc 60.97% <33.33%> (ø)
src/nameserver/name_server_impl.cc 44.85% <37.14%> (ø)
src/schema/index_util.cc 77.47% <75.00%> (ø)

... and 522 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumianph
Copy link
Collaborator

add a message to tell the user that it is an async task

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 25, 2023
@dl239 dl239 enabled auto-merge (squash) August 28, 2023 06:37
@dl239 dl239 merged commit bc00d67 into 4paradigm:main Aug 31, 2023
dl239 added a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CREATE INDEX does not check the type of ts column
4 participants