Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unsupport create table like when database is not found #3379

Merged

Conversation

emo-coder
Copy link
Contributor

@emo-coder emo-coder commented Jul 19, 2023

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 19, 2023
@emo-coder emo-coder changed the title feat: not support CREATE TABLE LIKE HIVE when database is not found feat: unsupport CREATE TABLE LIKE HIVE when database is not found Jul 19, 2023
@emo-coder emo-coder changed the title feat: unsupport CREATE TABLE LIKE HIVE when database is not found feat: unsupport create table like when database is not found Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 21.42% and project coverage change: +38.42 🎉

Comparison is base (064a515) 37.25% compared to head (6f192c2) 75.67%.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3379       +/-   ##
=============================================
+ Coverage     37.25%   75.67%   +38.42%     
  Complexity      414      414               
=============================================
  Files           177      700      +523     
  Lines         10294   126597   +116303     
  Branches       1206     1206               
=============================================
+ Hits           3835    95804    +91969     
- Misses         6218    30552    +24334     
  Partials        241      241               
Impacted Files Coverage Δ
src/sdk/db_sdk.cc 67.46% <0.00%> (ø)
src/sdk/db_sdk.h 92.68% <ø> (ø)
src/sdk/sql_cluster_router.cc 60.97% <37.50%> (ø)

... and 520 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/sdk/sql_cluster_test.cc Outdated Show resolved Hide resolved
@emo-coder emo-coder requested a review from dl239 July 20, 2023 02:53
@dl239 dl239 marked this pull request as ready for review July 20, 2023 07:36
@dl239 dl239 requested a review from vagetablechicken July 24, 2023 09:33
@dl239 dl239 merged commit 1db10b0 into 4paradigm:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CREATE TABLE LIKE HIVE should return failed when database is not found
4 participants