Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: diag tool setup requires and ci test #3285

Merged
merged 10 commits into from
May 30, 2023
Merged

fix: diag tool setup requires and ci test #3285

merged 10 commits into from
May 30, 2023

Conversation

zhangziheng01233
Copy link
Contributor

add requests in tool setup requires

@github-actions github-actions bot added the sdk openmldb java/python sdk label May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d2a8300) 75.58% compared to head (d684340) 75.59%.

Additional details and impacted files 
@@            Coverage Diff             @@
##               main    #3285    +/-   ##
==========================================
  Coverage     75.58%   75.59%            
  Complexity      393      393            
==========================================
  Files           681      686     +5     
  Lines        125697   125836   +139     
  Branches       1186     1186            
==========================================
+ Hits          95014    95128   +114     
- Misses        30446    30471    +25     
  Partials        237      237
Impacted Files Coverage Δ
python/openmldb_tool/tests/case_conf.py 100.00% <100.00%> (ø)
python/openmldb_tool/tests/cmd_test.py 95.65% <100.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the workflow CICD related label May 18, 2023
@vagetablechicken vagetablechicken changed the title fix: diag tool setup requires fix: diag tool setup requires and ci test May 18, 2023
@vagetablechicken vagetablechicken enabled auto-merge (squash) May 30, 2023 12:36
@vagetablechicken vagetablechicken merged commit 54cedd6 into 4paradigm:main May 30, 2023
@zhangziheng01233 zhangziheng01233 deleted the fix_req branch May 31, 2023 01:26
@vagetablechicken vagetablechicken linked an issue Jun 1, 2023 that may be closed by this pull request
ci: add python diag tool test #3277
Closed
dl239 pushed a commit that referenced this pull request Jun 29, 2023
@zhangziheng01233 @dl239
fix: diag tool setup requires and ci test (#3285)
68cf529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagetablechicken vagetablechicken vagetablechicken approved these changes

@aceforeverd aceforeverd aceforeverd approved these changes

Assignees
No one assigned
Labels
sdk openmldb java/python sdk workflow CICD related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: add python diag tool test
3 participants
@zhangziheng01233 @aceforeverd @vagetablechicken