Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(round): explicitly turn off bool type as first param of round #3234

Merged
merged 1 commit into from
May 4, 2023

Conversation

aceforeverd
Copy link
Collaborator

This is a word around to the core fail in export_udf_info

This is a word around to the core fail in export_udf_info
@aceforeverd aceforeverd marked this pull request as ready for review April 26, 2023 09:56
@github-actions github-actions bot added the execute-engine hybridse sql engine label Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (ff3a355) 75.61% compared to head (e3f27a8) 75.58%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3234      +/-   ##
============================================
- Coverage     75.61%   75.58%   -0.04%     
  Complexity      393      393              
============================================
  Files           681      681              
  Lines        125633   125643      +10     
  Branches       1181     1181              
============================================
- Hits          94996    94964      -32     
- Misses        30401    30443      +42     
  Partials        236      236              
Impacted Files Coverage Δ
hybridse/src/codegen/udf_ir_builder_test.cc 98.83% <100.00%> (+<0.01%) ⬆️
hybridse/src/udf/default_udf_library.cc 97.28% <100.00%> (+0.29%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aceforeverd aceforeverd merged commit bd7cbe8 into 4paradigm:main May 4, 2023
@aceforeverd aceforeverd deleted the fix-udf-doc-gen branch May 4, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants