Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3087): correct schema for asterisk project over multiple join #3117

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Mar 1, 2023

close #3087

PhysicalOpJoinNode::InitSchema not take table & db name if input source is JoinNode

@github-actions github-actions bot added the execute-engine hybridse sql engine label Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (7e653e2) 75.69% compared to head (23973e1) 75.68%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3117      +/-   ##
============================================
- Coverage     75.69%   75.68%   -0.01%     
  Complexity      393      393              
============================================
  Files           672      672              
  Lines        124852   124864      +12     
  Branches       1140     1140              
============================================
+ Hits          94501    94505       +4     
- Misses        30115    30123       +8     
  Partials        236      236              
Impacted Files Coverage Δ
hybridse/src/vm/schemas_context.cc 90.02% <100.00%> (+0.25%) ⬆️
hybridse/src/codec/type_codec.cc 74.88% <0.00%> (-0.92%) ⬇️
src/log/log_reader.cc 80.62% <0.00%> (-0.86%) ⬇️
src/catalog/tablet_catalog.cc 70.74% <0.00%> (-0.80%) ⬇️
src/sdk/db_sdk.cc 65.18% <0.00%> (-0.45%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.26% <0.00%> (-0.32%) ⬇️
src/sdk/sql_cluster_router.cc 61.94% <0.00%> (-0.12%) ⬇️
src/nameserver/name_server_impl.cc 44.68% <0.00%> (-0.05%) ⬇️
src/client/tablet_client.cc 58.88% <0.00%> (ø)
hybridse/src/vm/runner.cc 67.70% <0.00%> (+0.07%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

SDK Test Report

  91 files    91 suites   1m 24s ⏱️
184 tests 174 ✔️ 10 💤 0
230 runs  220 ✔️ 10 💤 0

Results for commit 23973e1.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit 4cbd38d into 4paradigm:main Mar 3, 2023
@aceforeverd aceforeverd deleted the fix-3087 branch March 13, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select * over two last join fails during compile: Project node's function info is not valid
4 participants