Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get job fail status for show job commands #3112

Merged

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub commented Mar 1, 2023

If the internal table is corrupt, we will get the error message now.

show_job_fail

@tobegit3hub tobegit3hub self-assigned this Mar 1, 2023
@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (7e653e2) 75.69% compared to head (8ad9f17) 75.62%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3112      +/-   ##
============================================
- Coverage     75.69%   75.62%   -0.07%     
  Complexity      393      393              
============================================
  Files           672      666       -6     
  Lines        124852   124454     -398     
  Branches       1140     1140              
============================================
- Hits          94501    94117     -384     
+ Misses        30115    30101      -14     
  Partials        236      236              
Impacted Files Coverage Δ
src/sdk/sql_cluster_router.cc 62.04% <0.00%> (-0.02%) ⬇️
src/sdk/sql_cluster_router.h 0.00% <ø> (ø)
hybridse/src/codec/type_codec.cc 74.88% <0.00%> (-0.92%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.26% <0.00%> (-0.32%) ⬇️
src/client/tablet_client.cc 58.77% <0.00%> (-0.12%) ⬇️
src/tablet/tablet_impl.cc 63.53% <0.00%> (-0.10%) ⬇️
src/nameserver/name_server_impl.cc 44.69% <0.00%> (-0.03%) ⬇️
python/openmldb_sdk/tests/openmldb_client_test.py
python/openmldb_sdk/tests/sql_magic_test.py
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

SDK Test Report

  91 files    91 suites   1m 28s ⏱️
184 tests 174 ✔️ 10 💤 0
230 runs  220 ✔️ 10 💤 0

Results for commit 8ad9f17.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Linux Test Report

       56 files       230 suites   1h 16m 18s ⏱️
11 923 tests 11 916 ✔️ 7 💤 0
16 924 runs  16 917 ✔️ 7 💤 0

Results for commit 8ad9f17.

♻️ This comment has been updated with latest results.

@tobegit3hub tobegit3hub merged commit df89712 into 4paradigm:main Mar 3, 2023
@lumianph lumianph added the alpha this feature is not fully tested or functional label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha this feature is not fully tested or functional storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add error msg when GetJobResultSet failed
4 participants