Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add udf for string to timestamp and ut #3088

Merged

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub self-assigned this Feb 21, 2023
@github-actions github-actions bot added the batch-engine openmldb batch(offline) engine label Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 36.46% // Head: 75.71% // Increases project coverage by +39.25% 🎉

Coverage data is based on head (1c18f39) compared to base (f178654).
Patch coverage: 78.94% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3088       +/-   ##
=============================================
+ Coverage     36.46%   75.71%   +39.25%     
  Complexity      393      393               
=============================================
  Files           160      666      +506     
  Lines          9624   124775   +115151     
  Branches       1132     1091       -41     
=============================================
+ Hits           3509    94477    +90968     
- Misses         5879    30062    +24183     
  Partials        236      236               
Impacted Files Coverage Δ
...adigm/openmldb/batch/nodes/SimpleProjectPlan.scala 75.00% <50.00%> (+9.61%) ⬆️
...radigm/openmldb/batch/nodes/ConstProjectPlan.scala 10.34% <86.66%> (+8.82%) ⬆️
src/sdk/sql_router.cc 2.83% <0.00%> (ø)
hybridse/include/base/raw_buffer.h 12.50% <0.00%> (ø)
src/base/file_util.h 81.86% <0.00%> (ø)
hybridse/src/codegen/scope_var.cc 64.81% <0.00%> (ø)
hybridse/src/codegen/aggregate_ir_builder_test.cc 100.00% <0.00%> (ø)
src/base/proto_util.h 100.00% <0.00%> (ø)
hybridse/src/vm/jit_wrapper_test.cc 95.34% <0.00%> (ø)
...xamples/toydb/src/testing/toydb_engine_test_base.h 52.87% <0.00%> (ø)
... and 499 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

SDK Test Report

  88 files    88 suites   1m 32s ⏱️
182 tests 173 ✔️ 9 💤 0
228 runs  219 ✔️ 9 💤 0

Results for commit 1c18f39.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

Linux Test Report

       56 files       230 suites   1h 16m 46s ⏱️
11 923 tests 11 916 ✔️ 7 💤 0
16 924 runs  16 917 ✔️ 7 💤 0

Results for commit 1c18f39.

♻️ This comment has been updated with latest results.

@tobegit3hub tobegit3hub enabled auto-merge (squash) February 28, 2023 03:27
@tobegit3hub tobegit3hub merged commit c63f553 into 4paradigm:main Feb 28, 2023
dl239 pushed a commit to dl239/OpenMLDB that referenced this pull request Mar 21, 2023
* Add udf for string to timestamp and ut

* Handle illegal string length and return null
dl239 pushed a commit that referenced this pull request Mar 22, 2023
* Add udf for string to timestamp and ut

* Handle illegal string length and return null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select timestamp(string_val) will get null data
3 participants