Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix offline job fail message inc CLI and set offline job status if spark job fails #3080

Merged

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub self-assigned this Feb 17, 2023
@github-actions github-actions bot added storage-engine openmldb storage engine. nameserver & tablet task-manager openmldb taskmanager labels Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 75.69% // Head: 36.44% // Decreases project coverage by -39.25% ⚠️

Coverage data is based on head (bf89560) compared to base (61ee03d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3080       +/-   ##
=============================================
- Coverage     75.69%   36.44%   -39.25%     
  Complexity      393      393               
=============================================
  Files           664      160      -504     
  Lines        124607     9623   -114984     
  Branches       1113     1114        +1     
=============================================
- Hits          94319     3507    -90812     
+ Misses        30052     5880    -24172     
  Partials        236      236               
Impacted Files Coverage Δ
...m/_4paradigm/openmldb/taskmanager/dao/JobInfo.java 0.00% <0.00%> (ø)
...nmldb/taskmanager/server/impl/TaskManagerImpl.java 0.00% <0.00%> (ø)
src/client/taskmanager_client.cc
src/sdk/sql_cluster_router.cc
hybridse/src/vm/runner.h
hybridse/src/vm/runner_test.cc
hybridse/include/vm/catalog.h
hybridse/include/codec/fe_schema_codec.h
src/storage/disk_table_test.cc
...bridse/examples/toydb/src/storage/skiplist_test.cc
... and 496 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023

SDK Test Report

  89 files    89 suites   1m 29s ⏱️
180 tests 171 ✔️ 9 💤 0
226 runs  217 ✔️ 9 💤 0

Results for commit bf89560.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Linux Test Report

       56 files       230 suites   1h 14m 49s ⏱️
11 890 tests 11 883 ✔️ 7 💤 0
16 876 runs  16 869 ✔️ 7 💤 0

Results for commit bf89560.

@tobegit3hub tobegit3hub enabled auto-merge (squash) February 28, 2023 03:27
@tobegit3hub tobegit3hub merged commit b2d1f54 into 4paradigm:main Feb 28, 2023
@lumianph lumianph added the alpha this feature is not fully tested or functional label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha this feature is not fully tested or functional storage-engine openmldb storage engine. nameserver & tablet task-manager openmldb taskmanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI show success even if create table like fail
4 participants