Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support sortby plan and add a unit test for it #296

Merged
merged 13 commits into from
Aug 24, 2021
Merged

feat: support sortby plan and add a unit test for it #296

merged 13 commits into from
Aug 24, 2021

Conversation

zekai427
Copy link
Contributor

@zekai427 zekai427 commented Aug 23, 2021 •
edited
Loading

@zekai427 zekai427 changed the title Testorder feat: support sortby plan Aug 23, 2021
@zekai427 zekai427 linked an issue Aug 23, 2021 that may be closed by this pull request
Support SortByPlan in SparkSQL #295
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2021 •
edited
Loading

Linux Test Report

     48 files  ±0     121 suites  ±0   34m 56s ⏱️ ±0s
7 959 tests ±0  7 956 ✔️ ±0  0 💤 ±0  3 ❌ ±0 
7 963 runs  ±0  7 960 ✔️ ±0  0 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 392ea62. ± Comparison against base commit 392ea62.

♻️ This comment has been updated with latest results.

@zekai427 zekai427 mentioned this pull request Aug 23, 2021
Merged
@zekai427 zekai427 changed the title feat: support sortby plan feat: support sortby plan and add a unit test for it Aug 23, 2021
tobegit3hub
tobegit3hub approved these changes Aug 23, 2021
View reviewed changes
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

java/openmldb-batch/src/main/scala/com/_4paradigm/openmldb/batch/utils/PhysicalNodeUtil.scala Outdated Show resolved Hide resolved
java/openmldb-batch/src/test/scala/com/_4paradigm/openmldb/batch/end2end/TestOrderBy.scala Outdated Show resolved Hide resolved
tobegit3hub
tobegit3hub approved these changes Aug 24, 2021
View reviewed changes
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zekai427 zekai427 added the enhancement New feature or request label Aug 24, 2021
@zekai427 zekai427 self-assigned this Aug 24, 2021
@zekai427 zekai427 added this to the v0.3 milestone Aug 24, 2021
@dl239 dl239 merged commit 392ea62 into 4paradigm:main Aug 24, 2021
@github-actions
Copy link
Contributor

HybridSE Linux Test Report

       71 files  ±0       220 suites  ±0   6m 0s ⏱️ ±0s
18 036 tests ±0  18 036 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
18 043 runs  ±0  18 043 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 392ea62. ± Comparison against base commit 392ea62.

@github-actions
Copy link
Contributor

HybridSE Mac Test Report

       71 files  ±0       220 suites  ±0   5m 49s ⏱️ ±0s
18 036 tests ±0  18 036 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
18 043 runs  ±0  18 043 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 392ea62. ± Comparison against base commit 392ea62.

@zekai427 zekai427 deleted the testorder branch August 30, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobegit3hub tobegit3hub tobegit3hub approved these changes

@dl239 dl239 dl239 approved these changes

Assignees

@zekai427 zekai427

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.3
Development

Successfully merging this pull request may close these issues.

Support SortByPlan in SparkSQL
3 participants
@zekai427 @tobegit3hub @dl239