Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support bitwise functions #244

Merged
merged 16 commits into from
Aug 16, 2021

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Aug 10, 2021

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

close #225 .

  1. support bitwise operators:
  • &
  • |
  • ^
  • ~
  1. fix some clang-tidy lint report in codegen
  • avoid use _ in google test name
  • use static_cast/dynamic_cast/reinterpret_cast instead of C-style convert
  • do not use using in header file
  1. type infer
  • both lhs and rhs should be int16, int32, int64
  • nullable

TODO

  • update example test

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2021

Linux Test Report

     47 files  ±0     119 suites  ±0   33m 25s ⏱️ ±0s
7 508 tests ±0  7 507 ✔️ ±0  0 💤 ±0  1 ❌ ±0 
7 508 runs  ±0  7 500 ✔️ ±0  0 💤 ±0  8 ❌ ±0 

For more details on these failures, see this check.

Results for commit 04bec58. ± Comparison against base commit 04bec58.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #244 (6f1879b) into main (c92d7a5) will increase coverage by 0.13%.
The diff coverage is 95.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #244      +/-   ##
============================================
+ Coverage     81.63%   81.77%   +0.13%     
  Complexity       13       13              
============================================
  Files           283      283              
  Lines         50128    50417     +289     
  Branches         29       29              
============================================
+ Hits          40924    41230     +306     
+ Misses         9195     9178      -17     
  Partials          9        9              
Impacted Files Coverage Δ
hybridse/include/node/type_node.h 91.17% <ø> (ø)
hybridse/src/codegen/block_ir_builder.cc 68.02% <ø> (ø)
hybridse/src/codegen/codegen_base_test.h 86.66% <ø> (ø)
hybridse/src/codegen/cond_select_ir_builder.cc 100.00% <ø> (ø)
hybridse/src/codegen/date_ir_builder.cc 68.21% <ø> (ø)
hybridse/src/codegen/fn_let_ir_builder.cc 93.98% <ø> (ø)
hybridse/src/codegen/ir_base_builder.h 100.00% <ø> (+57.14%) ⬆️
hybridse/src/codegen/list_ir_builder.cc 100.00% <ø> (ø)
hybridse/src/passes/expression/simplify.h 100.00% <ø> (ø)
hybridse/src/udf/default_udf_library.cc 96.04% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c92d7a5...6f1879b. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2021

HybridSE Linux Test Report

       71 files  ±0       220 suites  ±0   5m 28s ⏱️ ±0s
17 929 tests ±0  17 929 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
17 936 runs  ±0  17 936 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 04bec58. ± Comparison against base commit 04bec58.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2021

HybridSE Mac Test Report

       71 files  ±0       220 suites  ±0   5m 58s ⏱️ ±0s
17 929 tests ±0  17 929 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
17 936 runs  ±0  17 936 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 04bec58. ± Comparison against base commit 04bec58.

♻️ This comment has been updated with latest results.

@aceforeverd aceforeverd marked this pull request as ready for review August 12, 2021 10:00
@aceforeverd aceforeverd requested a review from imotai August 15, 2021 03:22
Copy link
Collaborator

@jingchen2222 jingchen2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imotai imotai merged commit 04bec58 into 4paradigm:main Aug 16, 2021
@aceforeverd aceforeverd deleted the feat/225-bitwise-functions branch August 16, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitwise function: &, |, ^, ~
4 participants