-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support bitwise functions #244
feat: support bitwise functions #244
Conversation
- '&' - '|' - '^' - '~'
fix some clang-tidy reports as well
Linux Test Report 47 files ±0 119 suites ±0 33m 25s ⏱️ ±0s For more details on these failures, see this check. Results for commit 04bec58. ± Comparison against base commit 04bec58. ♻️ This comment has been updated with latest results. |
Codecov Report
@@ Coverage Diff @@
## main #244 +/- ##
============================================
+ Coverage 81.63% 81.77% +0.13%
Complexity 13 13
============================================
Files 283 283
Lines 50128 50417 +289
Branches 29 29
============================================
+ Hits 40924 41230 +306
+ Misses 9195 9178 -17
Partials 9 9
Continue to review full report at Codecov.
|
on: - pull request that changes hybridse files - manual trigger
- fix some lint report in codegen
- snake case is prohibited by google test style
- only accept NULL, int16, int32, int64 - add test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #225 .
&
|
^
~
_
in google test nameusing
in header filelhs
andrhs
should beint16
,int32
,int64
TODO