chore: Setup eslint for packages/nuqs #582
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing the lint setup I created when debugging #566 in case linting is desired going forward.
This is mostly the default setup from
npm init @eslint/config@latest
with eslint 8, react, and ts. I added eslint-plugin-react-hooks & eslint-plugin-react-compiler.I disabled the following rules because they throw errors in the current codebase that I didn't find particularly useful here:
I also disabled eslint entirely in the
*.test-d.ts
files because those threw many errors with the rules of hooks and if the current usage of those files works fine for testing, I don't see any reason to lint there (at least for the rules of hooks).Lastly, there are just a few warnings related to dependency arrays of the current hook usages:
These can be fixed very easily, but I will wait for feedback on how y'all would like to fix them (or not fix them) before making further changes.