Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to raise an error when string is not terminated #421

Merged
merged 5 commits into from
Nov 15, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions norminette/lexer/lexer.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ def read_file(filename):


class TokenError(Exception):
def __init__(self, pos):
self.msg = f"Error: Unrecognized token line {pos[0]}, col {pos[1]}"
def __init__(self, pos, message=None):
self.msg = message or f"Error: Unrecognized token line {pos[0]}, col {pos[1]}"

def __repr__(self):
return self.msg
Expand Down Expand Up @@ -114,6 +114,8 @@ def string(self):
self.__line_pos = 1
if self.peek_char() == '"':
break
if self.peek_char() == '\n':
raise TokenError(pos, f"String literal unterminated detected at line {pos[0]}")
self.pop_char()
else:
raise TokenError(pos)
Expand Down