Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unecessary _ assignment which stops Xcode 12 from compiling #48

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Removes unecessary _ assignment which stops Xcode 12 from compiling #48

merged 1 commit into from
Sep 17, 2020

Conversation

simonmitchell
Copy link
Contributor

Description

Allows compiling against the Swift 5.3 compiler

Motivation and Context

Allowing use of Xcode 12 for compiling our apps

How Has This Been Tested?

Has been tested in Simon's own "Camrote" app

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@simonmitchell simonmitchell merged commit f20b2c2 into develop Sep 17, 2020
@BenShutt BenShutt deleted the feature/Xcode_12_support branch August 25, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenShutt BenShutt BenShutt approved these changes

@m0wo m0wo Awaiting requested review from m0wo

@RodrigoLondon RodrigoLondon Awaiting requested review from RodrigoLondon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonmitchell @BenShutt