Post Notification when a .notConnectedToInternet URLError is re…
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turned as the `Error` of a URL task
| @@ -74,6 +79,10 @@ extension RequestController { | |||
|
|
|||
| NotificationCenter.default.post(name: RequestController.DidReceiveResponseNotificationName, object: nil, userInfo: requestInfo) | |||
|
|
|||
| if let urlError = error as? URLError, urlError.code == .notConnectedToInternet { | |||
There was a problem hiding this comment.
Should we be more generic here and have a notification similar to below? RequestController.DidNetworkErrorNotificationName? We could just whack the error into the requestInfo dictionary and do the checking in the consuming app then?
There was a problem hiding this comment.
Hmmm that's not a bad point at all. Maybe al URLErrors? can easily then check for urlError.code == .notConnectedToInternet. I'll make that change if you agree? Or have any other suggestions?
simonmitchell
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post
Notificationwhen a.notConnectedToInternetURLErroris returned as theErrorof a URL taskRelated Issue
Motivation and Context
Apps can listen and respond to this
Notificationand handle accordingly, often with UI.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: