spec/proxy: bring rejection reason extraction test from cache_handler

Also stop checking whether the cache_handler methods return true or
false, they no longer return that.

spec/backend/cache_handler_spec.lua

@@ -1,12 +1,7 @@
-
 local _M = require('apicast.backend.cache_handler')
 local lrucache = require('resty.lrucache')
 
-local response = require('resty.http_ng.response')
-
-
 describe('Cache Handler', function()
-
   describe('.new', function()
     it('has a default handler', function()
       local handler = _M.new()
@@ -37,7 +32,7 @@ describe('Cache Handler', function()
       local cache = lrucache.new(1)
       ngx.var = { cached_key = nil }
 
-      assert.truthy(handler(cache, 'foobar', { status = 200 }))
+      handler(cache, 'foobar', { status = 200 })
 
       assert.equal(200, cache:get('foobar'))
     end)
@@ -46,7 +41,7 @@ describe('Cache Handler', function()
       local cache = lrucache.new(1)
       ngx.var = { cached_key = 'foobar' } -- means it is performed in post_action
 
-      assert.truthy(handler(cache, 'foobar', { status = 200 }))
+      handler(cache, 'foobar', { status = 200 })
 
       assert.falsy(cache:get('foobar'))
     end)
@@ -55,7 +50,7 @@ describe('Cache Handler', function()
       local cache = lrucache.new(1)
       cache:set('foobar', 200)
 
-      assert.falsy(handler(cache, 'foobar', { status = 403 }))
+      handler(cache, 'foobar', { status = 403 })
 
       assert.falsy(cache:get('foobar'))
     end)
@@ -64,47 +59,35 @@ describe('Cache Handler', function()
       local cache = lrucache.new(1)
       cache:set('foobar', 200)
 
-      assert.falsy(handler(cache, 'foobar', { status = 503 }))
+      handler(cache, 'foobar', { status = 503 })
 
       assert.falsy(cache:get('foobar'))
     end)
-
-    it('returns a rejection reason when given', function()
-      local cache = lrucache.new(1)
-
-      local authorized, rejection_reason = handler(
-        cache, 'foobar', response.new(nil, 403, { ['3scale-rejection-reason'] = 'some_reason' }, ''))
-
-      assert.falsy(authorized)
-      assert.equal('some_reason', rejection_reason)
-      assert.falsy(cache:get('foobar'))
-    end)
   end)
 
-
   describe('resilient', function()
     local handler = _M.handlers.resilient
 
     it('caches successful response', function()
       local cache = lrucache.new(1)
 
-      assert.truthy(handler(cache, 'foobar', { status = 200 }))
+      handler(cache, 'foobar', { status = 200 })
 
       assert.equal(200, cache:get('foobar'))
     end)
 
     it('caches forbidden response', function()
       local cache = lrucache.new(1)
 
-      assert.falsy(handler(cache, 'foobar', { status = 403 }))
+      handler(cache, 'foobar', { status = 403 })
 
       assert.equal(403, cache:get('foobar'))
     end)
 
     it('not caches server errors', function()
       local cache = lrucache.new(1)
 
-      assert.falsy(handler(cache, 'foobar', { status = 503 }))
+      handler(cache, 'foobar', { status = 503 })
 
       assert.falsy(cache:get('foobar'))
     end)
@@ -114,21 +97,10 @@ describe('Cache Handler', function()
 
       cache:set('foobar', 200)
 
-      assert.falsy(handler(cache, 'foobar', { status = 503 }))
+      handler(cache, 'foobar', { status = 503 })
 
       assert.equal(200, cache:get('foobar'))
     end)
-
-    it('returns a rejection reason when given', function()
-      local cache = lrucache.new(1)
-
-      local authorized, rejection_reason = handler(
-        cache, 'foobar', response.new(nil, 403, { ['3scale-rejection-reason'] = 'some_reason' }, ''))
-
-      assert.falsy(authorized)
-      assert.equal('some_reason', rejection_reason)
-      assert.equal(403, cache:get('foobar'))
-    end)
   end)
 
 end)

spec/proxy_spec.lua

@@ -1,3 +1,6 @@
+local response = require('resty.http_ng.response')
+local lrucache = require('resty.lrucache')
+
 local configuration_store = require 'apicast.configuration_store'
 local Service = require 'apicast.configuration.service'
 
@@ -109,4 +112,16 @@ describe('Proxy', function()
       assert.spy(proxy.cache_handler).was.called_with(proxy.cache, 'client_id=blah:foo=0', response, nil)
     end)
   end)
+
+  describe('.handle_backend_response', function()
+    it('returns a rejection reason when given', function()
+      local authorized, rejection_reason = proxy:handle_backend_response(
+        lrucache.new(1),
+        response.new(nil, 403, { ['3scale-rejection-reason'] = 'some_reason' }, ''),
+        nil)
+
+      assert.falsy(authorized)
+      assert.equal('some_reason', rejection_reason)
+    end)
+  end)
 end)