-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import oas include activedocs #103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3a744f
to
37b26f4
Compare
37b26f4
to
8a980c5
Compare
mikz
reviewed
Mar 7, 2019
lib/3scale_toolbox/commands/import_command/openapi/create_activedocs_step.rb
Outdated
Show resolved
Hide resolved
mikz
reviewed
Mar 7, 2019
8a980c5
to
96bb294
Compare
mikz
reviewed
Mar 7, 2019
lib/3scale_toolbox/commands/import_command/openapi/create_activedocs_step.rb
Outdated
Show resolved
Hide resolved
mikz
reviewed
Mar 7, 2019
lib/3scale_toolbox/commands/import_command/openapi/create_method_step.rb
Outdated
Show resolved
Hide resolved
mikz
approved these changes
Mar 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd seriously consider changing those unless + nil conditions into a more positive form and use variables.
96bb294
to
c6f5413
Compare
changed those unless + nil conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenAPI Specification used to create the service is pushed as an ActiveDocs file, using the same system_name as the service.
This PR partially covers issue #90
Still missing: This OpenAPI Specification is patched to take into account the new environment:
The missing parts will be included in another PR