Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import oas include activedocs #103

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented Mar 6, 2019

The OpenAPI Specification used to create the service is pushed as an ActiveDocs file, using the same system_name as the service.

This PR partially covers issue #90
Still missing: This OpenAPI Specification is patched to take into account the new environment:

  • the host field is updated with the hostname component of the public production base URL
  • the schemes field is updated with the scheme component of the public production base URL
  • the basePath field is updated if rewriting rules have been set
  • the securityDefinitions//authorizationUrl and securityDefinitions//tokenUrl fields are updated with the token and authorize endpoints listed in the OpenID Connect wellknown endpoint (when OIDC is in use)

The missing parts will be included in another PR

@eguzki eguzki changed the title [QIPImport oas include activedocs [WIP] Import oas include activedocs Mar 6, 2019
@eguzki eguzki force-pushed the import-oas-include-activedocs branch from b3a744f to 37b26f4 Compare March 6, 2019 21:23
@eguzki eguzki changed the title [WIP] Import oas include activedocs Import oas include activedocs Mar 6, 2019
@eguzki eguzki force-pushed the import-oas-include-activedocs branch from 37b26f4 to 8a980c5 Compare March 6, 2019 22:13
@eguzki eguzki force-pushed the import-oas-include-activedocs branch from 8a980c5 to 96bb294 Compare March 7, 2019 15:22
@eguzki eguzki requested a review from mikz March 7, 2019 15:23
Copy link
Contributor

@mikz mikz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd seriously consider changing those unless + nil conditions into a more positive form and use variables.

@eguzki eguzki force-pushed the import-oas-include-activedocs branch from 96bb294 to c6f5413 Compare March 7, 2019 15:51
@eguzki
Copy link
Member Author

eguzki commented Mar 7, 2019

changed those unless + nil conditions

@eguzki eguzki merged commit 034a29a into master Mar 7, 2019
@eguzki eguzki deleted the import-oas-include-activedocs branch March 7, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants