Ensure sysctl kernel.hostname set correctly #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code to set kernel.hostname in /etc/sysctl.conf didn't allow for a temporary change of hostname that is later reverted. For example, if the hostname is originally set to foo.example.com, is then changed to bar.example.com and later reverted to foo.example.com, the last kernel.hostname entry in /etc/sysctl.conf will remain bar.example.com, because the guard condition looks for any match in /etc/sysctl.conf Fixed by editing existing entries where applicable and updating the guard condition to find and match on the last kernel.hostname line
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to set kernel.hostname in /etc/sysctl.conf didn't allow for a
temporary change of hostname that is later reverted. For example, if
the hostname is originally set to foo.example.com, is then changed to
bar.example.com and later reverted to foo.example.com, the last
kernel.hostname entry in /etc/sysctl.conf will remain bar.example.com,
because the guard condition looks for any match in /etc/sysctl.conf
Fixed by editing existing entries where applicable and updating the
guard condition to find and match on the last kernel.hostname line