Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove wee_alloc as it's unmaintained #16

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

b41sh
Copy link
Contributor

@b41sh b41sh commented Sep 13, 2024

wee_alloc is no longer maintained - see rustwasm/wee_alloc#107 switch to the default Rust standard allocator.

@b41sh
Copy link
Contributor Author

b41sh commented Sep 15, 2024

PTAL @dmarteau

@dmarteau
Copy link
Member

Thx for the report.

It could be interesting to check for alternative, the gain in size was substantial.

@dmarteau
Copy link
Member

Thx for the report.

It could be interesting to check for alternative, the gain in size was substantial.

I, was wrong, this was not a so great gain after all (increase of 5Ko fro wasm build after wee-alloc removal)

@dmarteau dmarteau self-requested a review September 16, 2024 08:41
Copy link
Member

@dmarteau dmarteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmarteau dmarteau merged commit 8709f09 into 3liz:main Sep 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants