Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If rc.ErrShouldNotUseCache, skip all caching processes. #76

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

k1LoW
Copy link
Member

@k1LoW k1LoW commented Jun 13, 2024

Previously, the cache process was passed through even if Cacher.Load returned rc.ErrShouldNotUseCache, but this fix skips it all.

@k1LoW k1LoW self-assigned this Jun 13, 2024
@k1LoW k1LoW changed the title If rc.ErrShouldNotUseCache, skip all caching processes. If rc.ErrShouldNotUseCache, skip all caching processes. Jun 13, 2024
@k1LoW k1LoW added the minor label Jun 13, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Code Metrics Report

main (c46cabf) #76 (5f390da) +/-
Coverage 80.3% 60.8% -19.5%
Code to Test Ratio 1:2.3 1:2.3 -0.0
Test Execution Time 37s 43s +6s
Details
  |                     | main (c46cabf) | #76 (5f390da) |  +/-   |
  |---------------------|----------------|---------------|--------|
- | Coverage            |          80.3% |         60.8% | -19.5% |
  |   Files             |              7 |             7 |      0 |
  |   Lines             |            441 |           441 |      0 |
- |   Covered           |            354 |           268 |    -86 |
- | Code to Test Ratio  |          1:2.3 |         1:2.3 |   -0.0 |
  |   Code              |            727 |           729 |     +2 |
- |   Test              |           1690 |          1685 |     -5 |
- | Test Execution Time |            37s |           43s |    +6s |

Code coverage of files in pull request scope (80.4% → 47.5%)

Files Coverage +/-
rc.go 75.0% +1.5%
testutil/cacher.go 0.0% -91.7%

Reported by octocov

@k1LoW k1LoW requested a review from pyama86 June 13, 2024 06:44
Copy link

@pyama86 pyama86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!!!!!!!!!!!!!!1

@k1LoW k1LoW merged commit ae091a6 into main Jun 13, 2024
3 checks passed
@k1LoW k1LoW deleted the skip-recorder branch June 13, 2024 06:56
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants