Cleanup how GCP storage bucket is created #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move everything into the base chart, rather than the daskhub chart. No reason this has to be coupled with dask. And if we want to use `z2jh.get_config` in `hub.extraConfig` to dynamically set environment values, the config needs to be under jupyterhub. - Scope the resources more clearly to be gcp specific. - Move some repetitive name constructions to a _helpers.tpl file
damianavila
approved these changes
May 6, 2021
There was a problem hiding this comment.
This is great @yuvipanda!
It makes sense to move this into some specific GCP place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chart. No reason this has to be coupled with dask. And if we
want to use
z2jh.get_configinhub.extraConfigto dynamicallyset environment values, the config needs to be under jupyterhub.
Ref #368