Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to link to show on hover #22

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

dsoegijono
Copy link
Member

Add title to entry link so the title is shown on hover. This is useful for longer names that overflow and hidden by ellipsis
Screenshot 2022-12-27 at 11 02 48

@Carlgo11
Copy link
Member

Have you checked if it changes the size of index.html drastically?

@dsoegijono
Copy link
Member Author

Local:
Screenshot 2022-12-27 at 13 15 12

Live:
Screenshot 2022-12-27 at 13 15 33

@Carlgo11
Copy link
Member

73KiB when comparing raw file size. Worth it for the feature but when CQI is supported it could probably replace this.

@Carlgo11 Carlgo11 merged commit 30a2a9e into 2factorauth:master Dec 27, 2022
@dsoegijono dsoegijono deleted the feature/text-overflow-hover branch December 27, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants