Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] amend: Child window visibility handling #6598

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

ShiinaRinne
Copy link
Contributor

#6596

在这个提交中引入了错误的逻辑, 当有子窗口 (例如 settings ) 打开时, 如果通过 status bar 的按钮隐藏主窗口, 子窗口会被一起隐藏.
但当再次通过此按钮打开主窗口时, 子窗口不会被自动打开, 会导致无法再打开这个子窗口.

同时修复 #6596 (comment) 提到的错误

2dust#6596

When the main window is hidden, open child windows are mistakenly hidden as well.
This prevents reopening child windows after the main window is shown again.
@2dust
Copy link
Owner

2dust commented Jan 30, 2025

if (Utils.IsOSX() || _config.UiItem.Hide2TrayWhenClose) 这个还是改成 if ( _config.UiItem.Hide2TrayWhenClose)
这样每个平台的逻辑就是一样的,全部有用户自己设置参数决定。

@2dust 2dust merged commit c0f8b6b into 2dust:master Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants