[4.3] SUPP-33: fix import/delete rates #6677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasks app CSV has empty binary for all fields that are missing from uploaded CSV. This will cause kzd_rates to always return empty string and doc save with them in db. This will make sure all accessros has correct type ne_binary and handle situation when the value is empty binary so we save a clean JSON in db.
When a user deletes the rates from ratedeck db, it is soft deleted by default. This commit will try to update and ensure save the doc even if it is deleted.
During testing the rate import and delete tasks for SUPP-33, some errors were found. * fix import where ratedeck database was incorrectly formatted (like `ratedeck/`) because of `ratedeck_id` being an empty binary from CSV * fix delete returning result which causing crashes in `kt_task_worker` * in delete, group objects by db, also add better logging * convert import state to map * make a clean json to save to db: CSV missing fields are empty binary. Together with changes in kzd_rates make sure we are generating a clean JSON to be saved to db.
open_doc will ignore if pvt_deleted so update_doc will result in conflict again. Adding option to allow pvt_deleted doc. Also remove any previous pvt_deleted from doc on conflict save
…emove pvt_deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix import/delete rates in tasks app and cb_rates.
ratedeck/) because ofratedeck_idbeing an empty binary from CSVkt_task_workersure we are generating a clean JSON to be saved to db.