KAZOO-786 #10
KAZOO-786 #10
Conversation
|
Your second diff, "include normalization", won't be included. I'm not sure what build errors you're getting to need that change of path. What errors are you getting? File a bug and issue a pull request against it so we can see why you think its needed. We have no issues with it as is. I think your first diff is fine though, good to not coerce the types in this case. We are adding the single quotes around atoms to be explicit about their type - if you can adjust your patch to wrap true/false as 'true' and 'false', that'd be great! |
|
Hi James, THANKS! actually it was my first pull request and didn't noticed that the second you are building the whole thing with makefiles that in some cases i create the jira issue and tried to "start work" but i don't have the if possible, i would like to get early access to the kazoo source (back and thank you very much for reading this to the end. best regards On Tue, Apr 2, 2013 at 5:36 PM, James Aimonetti [email protected]:
Luis Azedo |
|
Hi, just one more thing, what are you guys using to edit the bigcouch views ? thanks On Tue, Apr 2, 2013 at 5:56 PM, Luis Azedo [email protected]:
Luis Azedo |
|
Howdy, I am using VIM to edit the views but their format bothers me (some are leading commas others trailing, some even mix this, and we haven't found a way we all agree on for putting JSON in a string). Ultimately we just keep doing what we have been until we come up with a better way, suggestions welcome! What errors did you find? We calculate it each time because it grew organically. Originally only jonny5 needed the amounts, then the UI started calculating it in the call history display in the browser. When we (backend guys) saw this we said we would send it so it was under our control and the easiest way to support CDRs that didnt have a precomputed amount was to simply do it each time. Its not too expensive as bigcouch only has to run the view on new CDRs (unless you flush the view indexs). Prior to v2.12 the calculation logic was specific to jonny5 (except for the part in whapps_util, which was left over from the our oldest module Trunkstore). We didnt want to make a dependency between jonny5 and the cdr whapp (or duplicate that code). However, now that Peter has built wht_utils the cdr whapp could safely execute the same logic as jonny5, adding a cost to the cdr prior to save. For backward compatibility the view will need to be able to calculate the cost if the precomputed is not present... Anyway we are about to significantly refactor cdr storage and I am sure this will be addressed :) Calling whapps_maintenance:refresh() will update all views in all account dbs as well as the aggregate dbs (accounts, sip_auth, ect). However since it attempts to write status to a stream (assumed to be the Erlang shell) you need to use blocking_refresh when calling it from the sup tool. IE: sup whapps_maintenance blocking_refresh Thanks! |
|
Hi, thanks for the info and explanations. about the errors... cdrs.json : crossbar_listing *and *transactions.json if one is billing with increments different than 60 it doesn't work because it was filed with KAZOO-731 just one more, why do we see 2 rows for each call in winkstart call history thanks. On Tue, Apr 2, 2013 at 9:11 PM, bitbashing [email protected] wrote:
Luis Azedo |
|
Ah nice find, thanks! If you want credit in the git history feel free to issue a separate pull request with the corrected view :) Kazoo keeps cdrs per-leg (channel). If you hit a ring group of four endpoints you will end up with five cdrs (the originating leg and four endpoints). One of the up-coming tasks is to thread the cdrs together so you see them grouped by call or condensed. That hasn't been designed fully yet but should be a simple backend improvement to the API. |
KAZOO-731: Cherry pick accepted commits from pull request #10
|
Thank you for your contribution! I have cherry-picked the parts change to the view and wh_util. With regards to your include normalization I was not able to compile with those changes. For example in cb_about.erl the include specifies the header is in the local directory but it is actually in the parent. I am not sure how you are able to compile it ;) If we can find a happy common ground that works for you and still compiles via our makefile I would be will do include it. For future reference, please submit as pull requests as specific as possible. We would have preferred to have seen this as three separate requests. |
|
Hi, thank you and sorry for the 3 inclusions (includes was not meant to be), the include will work if you change the makefile , change in blue i would prefer to, move the .hrl files to folder include and have the -I be On Wed, Apr 3, 2013 at 10:53 PM, bitbashing [email protected]:
Luis Azedo |
# This is the 1st commit message: doc_storage: add descriptions to schema update docs and swagger in the process # This is the commit message #2: doc_storage: start to document the storage API # This is the commit message #3: doc_storage: add schema description to table output # This is the commit message #4: doc_storage: update schema ref # This is the commit message #5: doc_storage: sort order to allowed methods # This is the commit message #6: doc_storage: add description # This is the commit message #7: doc_storage: add descriptions to google drive schema # This is the commit message #8: doc_storage: incorporate latest generated doc # This is the commit message #9: doc_storage: start blog about storage # This is the commit message #10: doc_storage: update header # This is the commit message #1: doc_storage: ignore "id" field in schema # This is the commit message #2: doc_storage: refactor to more functions, add log # This is the commit message #3: doc_storage: add patch support to cb_storage # This is the commit message #4: doc_storage: refactor to more functions # This is the commit message #5: doc_storage: handle additionalProperties schema fail # This is the commit message #6: doc_storage: get resp_status from right context # This is the commit message #7: doc_storage: add plan config # This is the commit message #8: doc_storage: add JSON for ref # This is the commit message #9: doc_storage: update markdown
* # This is a combination of 9 commits. # This is the 1st commit message: doc_storage: add descriptions to schema update docs and swagger in the process # This is the commit message #2: doc_storage: start to document the storage API # This is the commit message #3: doc_storage: add schema description to table output # This is the commit message #4: doc_storage: update schema ref # This is the commit message #5: doc_storage: sort order to allowed methods # This is the commit message #6: doc_storage: add description # This is the commit message #7: doc_storage: add descriptions to google drive schema # This is the commit message #8: doc_storage: incorporate latest generated doc # This is the commit message #9: doc_storage: start blog about storage # This is the commit message #10: doc_storage: update header # This is the commit message #1: doc_storage: ignore "id" field in schema # This is the commit message #2: doc_storage: refactor to more functions, add log # This is the commit message #3: doc_storage: add patch support to cb_storage # This is the commit message #4: doc_storage: refactor to more functions # This is the commit message #5: doc_storage: handle additionalProperties schema fail # This is the commit message #6: doc_storage: get resp_status from right context # This is the commit message #7: doc_storage: add plan config # This is the commit message #8: doc_storage: add JSON for ref # This is the commit message #9: doc_storage: update markdown * doc_storage: write basic guide to using storage * doc_storage: add xmerl to base PLT
* # This is a combination of 9 commits. # This is the 1st commit message: doc_storage: add descriptions to schema update docs and swagger in the process # This is the commit message #2: doc_storage: start to document the storage API # This is the commit message #3: doc_storage: add schema description to table output # This is the commit message 2600hz#4: doc_storage: update schema ref # This is the commit message 2600hz#5: doc_storage: sort order to allowed methods # This is the commit message 2600hz#6: doc_storage: add description # This is the commit message 2600hz#7: doc_storage: add descriptions to google drive schema # This is the commit message 2600hz#8: doc_storage: incorporate latest generated doc # This is the commit message 2600hz#9: doc_storage: start blog about storage # This is the commit message 2600hz#10: doc_storage: update header # This is the commit message 2600hz#1: doc_storage: ignore "id" field in schema # This is the commit message #2: doc_storage: refactor to more functions, add log # This is the commit message #3: doc_storage: add patch support to cb_storage # This is the commit message 2600hz#4: doc_storage: refactor to more functions # This is the commit message 2600hz#5: doc_storage: handle additionalProperties schema fail # This is the commit message 2600hz#6: doc_storage: get resp_status from right context # This is the commit message 2600hz#7: doc_storage: add plan config # This is the commit message 2600hz#8: doc_storage: add JSON for ref # This is the commit message 2600hz#9: doc_storage: update markdown * doc_storage: write basic guide to using storage * doc_storage: add xmerl to base PLT
# This is the 1st commit message: Merge the diff into the current doc and try saving again cleanup logging prefer the diff's value (excepting _rev) # This is the commit message #1: simplfy doc return # This is the commit message #2: only convert to binary if a list of ascii is present also don't convert kz_json:object() to null if found update tests accordingly # This is the commit message #3: use sets:subtract/2 to find the diff in J1 and J2 # This is the commit message #4: add ability to merge list of jobjs with strategy fun # This is the commit message #5: more diff testing # This is the commit message #6: flag ensure_saved as deprecated # This is the commit message #7: remove arity-4 export we can change arity-3 to accept options instead of the updates directly # This is the commit message #8: ignore return # This is the commit message #9: refactor update_doc to take an options list instead # This is the commit message #10: update account docs with update proplist # This is the commit message #11: add specs and update type # This is the commit message #12: update usage of kz_datamgr:update_doc # This is the commit message #13: update uses of update_doc # This is the commit message #14: expose paths for properties also fixes updating the version in the accounts DB # This is the commit message #15: expose the base properties being set # This is the commit message #16: use a setter # This is the commit message #17: expose more paths # This is the commit message #18: update uses of ensure_saved to use update_doc # This is the commit message #19: fix function call # This is the commit message #20: ignore returns # This is the commit message #21: less args passed around # This is the commit message #22: filter undefined # This is the commit message #23: takes a flat proplist # This is the commit message #24: match return # This is the commit message #25: use the saved version in future contexts # This is the commit message #26: just try to delete the doc without opening it # This is the commit message #27: handle returns # This is the commit message #28: handle return # This is the commit message #29: delete the doc directly, handle returns # This is the commit message #30: refactor a bit # This is the commit message #31: remove unreachable clause # This is the commit message #32: update spec # This is the commit message #33: expose more paths # This is the commit message #34: expose more paths # This is the commit message #35: fix specs # This is the commit message #36: match on proper return # This is the commit message #37: update spec # This is the commit message #38: update account docs # This is the commit message #39: should save the docs # This is the commit message #40: add missing types # This is the commit message #41: hackney wants a binary # This is the commit message #42: hackney wants a binary # This is the commit message #43: more strict checking of design docs # This is the commit message #44: update type # This is the commit message #45: update usages # This is the commit message #46: add announcement for 4.3 # This is the commit message #47: update spelling # This is the commit message #48: fix spelling # This is the commit message #49: ref the local fun # This is the commit message #50: save the accounts version if not_found # This is the commit message #51: return the account db version # This is the commit message #52: hide $ from formatter # This is the commit message #53: make sure to update the account doc # This is the commit message #54: move saving account docs to updates instaed # This is the commit message #55: right function name this time
https://2600hz.atlassian.net/browse/KAZOO-786