Feedback #1
Feedback #1
Conversation
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
add all assets
add parseStory function
add intial pages
adding hotkey enter event
input bg color and reset
added buttons with logic
Game page layout modifications
fixed scroll issue
styling span
added some styling to buttons
✅ Deploy Preview for jumanji-recoded ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fix paper prev and edit height mobile version
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width" /> | ||
| <title>Jumanji | Madlibs</title> |
There was a problem hiding this comment.
It's great that you added a meaningful title for the web page.
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width" /> | ||
| <title>Jumanji | Madlibs</title> | ||
| <link rel="preconnect" href="https://fonts.googleapis.com" /> |
There was a problem hiding this comment.
It's generally better to add Google Fonts to your CSS file rather than directly in your HTML file.
| <div class='madLibsPreview'> | ||
| </div> | ||
| <div id="content" class="content hidden"> | ||
| <div class="logoContainer"> |
There was a problem hiding this comment.
I see some classes are using kebab-case and others are using camelCase. It's good to stick to one system.
| </div> | ||
| </div> | ||
| </div> | ||
| <audio id="sound"> |
There was a problem hiding this comment.
I loved that you added sound to your project!
| <button class="start-btn" onclick="startBtn()">Start</button> | ||
| <div class="sound-btn" onclick="soundBtn()"> | ||
| <div class="checkbox"> | ||
| <img src="assets/icons8-checkmark-96.svg" alt="check icon" /> |
There was a problem hiding this comment.
It's great that all your images have alt attributes for accessibility.
| </head> | ||
|
|
||
| <body> | ||
| <div id="loading" class="loading"> |
There was a problem hiding this comment.
The loading animation is a nice addition for user experience.
| }, 2100); | ||
| }; | ||
|
|
||
| ///// sound btn |
There was a problem hiding this comment.
Consider adding comments to explain the purpose of event listeners, like the soundBtn function. It's not immediately clear what this function does without comments.
| ///// Start btn | ||
| const startBtn = () => { | ||
| const bab1 = document.querySelector(".bab1"); | ||
| const bab2 = document.querySelector(".bab2"); |
There was a problem hiding this comment.
Is bab referring to door? It would be better to stick with English in general.
| * There are multiple ways to do this, but you may want to use regular expressions. | ||
| * Please go through this lesson: https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/regular-expressions/ | ||
| */ | ||
| // document.body.style.overflow = "hidden"; | ||
|
|
||
| const progressFill = document.querySelector(".progress-fill"), |
There was a problem hiding this comment.
It's good that you added these at the top of the file!
| let arrWord = rawStory.split(" "); | ||
| let storyToObj = []; | ||
| arrWord.forEach((item) => { | ||
| if (item.match(/[[a-zA-Z]]/g)) { |
There was a problem hiding this comment.
It's good to have this item.match(/[[a-zA-Z]]/g) in a separate variable with a comment explaining the purpose.
fix overflow
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mastersince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mastersince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.master. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @fketta @ismail-benlaredj @hocine1212 @ikoworld @Ben-Tewfik @mounibzaidi