LG-13934 Add socure webhook #11101
Merged
LG-13934 Add socure webhook #11101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Route is now '/api/webhooks/socure/event'
changelog: Upcoming Features,Adding Socure support,Created a webhook for Socure to invoke during IdV
Removed empty generated code and changed spec for request to controller.
zachmargolis
approved these changes
Aug 16, 2024
Co-authored-by: Zach Margolis <[email protected]>
We're covered by a controller spec here; the request spec is redundant.
jmax-gsa
force-pushed
the
jmax/LG-13934-add-socure-webhook
branch
from
6bffdab to
7fc550f
Compare
zachmargolis
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13934
🛠 Summary of changes
Added a webhook at
/api/webhooks/socure/eventfor eventual use during doc auth with Socure.📜 Testing Plan
Notes:
It is necessary to have an account on the Socure console for these tests. Feel free to ask me for pairing if you don't have one; glad to pair.
Since the code under test is running as a review app, rather than a stable URL, it may be necessary to restart the review app and update its URL in the Socure console.
Running locally, use the command
curl http://localhost:3000/api/webhooks/socure/event --json '{"some":"value"}'to hit the webhook. Verify that this returns a200 OKstatus.Set up the Socure console to point at the review app with a path of
/api/webhooks/socure/eventVerify that you can use the Socure console to make a round-trip request to the webhook.
👀 Screenshots