LG-12532 Add 50/50 tests for IPP state id page #11090
Conversation
| @@ -36,7 +36,7 @@ | |||
| <%= link_to( | |||
| MarketingSite.help_center_article_url( | |||
| category: 'verify-your-identity', | |||
| article: 'accepted-state-issued-identification', | |||
| article: 'accepted-identification-documents', | |||
There was a problem hiding this comment.
I want to point out that this change was made due to the integration tests I added for state_id_controller.
I was getting an ActionView::Template::Error:Unknown help center article category verify-your-identity/accepted-state-issued-identification, so I updated it to the accepted-identification-documents article that was defined in the MarketingSite service.
shanechesnutt-ft
force-pushed
the
sc/LG-12532
branch
from
294efa7 to
365ba97
Compare
shanechesnutt-ft
force-pushed
the
sc/LG-12532
branch
from
365ba97 to
620b410
Compare
| @@ -0,0 +1,378 @@ | |||
| require 'rails_helper' | |||
|
|
|||
| RSpec.describe 'state id 50/50 state', js: true, allowed_extra_analytics: [:*], | |||
There was a problem hiding this comment.
Depending if #11099 is merged before this one, we should rebase and check whether allowed_extra_analytics is still necessary. Ideally we'd not be adding new instances of this, as it's meant for legacy only.
There was a problem hiding this comment.
Okay thanks for the heads up! I can rebase this branch off of the branch for the PR using git rebase --onto and try it out.
There was a problem hiding this comment.
After rebasing with your branch, it appears that the allow_extra_analytics is still needed. When I removed allowed_extra_analytics from the describe block I receive the following error message:
FakeAnalytics::UndocumentedParams:
event :idv_doc_auth_welcome_visited called with undocumented params [:opted_in_to_in_person_proofing]
(if these params are for specs only, use :allowed_extra_analytics metadata)
There was a problem hiding this comment.
The opted_in_to_in_person_proofing property seems to be coming from the ab_test_analytics_buckets method if that helps.
There was a problem hiding this comment.
Discussed on Slack, but we can either add the missing analytics event property documentation, or re-add allowed_extra_analytics. Ideally we're documenting all analytics methods, but I think it'd be fair to call it out of scope.
| click_send_link | ||
| end | ||
|
|
||
| perform_in_browser(:mobile) do |
There was a problem hiding this comment.
Nice use of these helpers for the hybrid flow!
| expect(page).to have_current_path(idv_in_person_verify_info_url, wait: 10) | ||
| click_button t('idv.buttons.change_state_id_label') | ||
|
|
||
| # state id page has fields that are pre-populated |
There was a problem hiding this comment.
Helpful comment for readability!
There was a problem hiding this comment.
Amazing work!! I read through the tests and ran them, they pass for me locally. Nice and comprehensive test coverage of the IPP flow when the controller variable is toggled on and off. Easy to understand, consistent, and descriptive nested contexts! Great usage of the helper methods throughout - I learned a lot reading through this!
LGTM!
shanechesnutt-ft
force-pushed
the
sc/LG-12532
branch
from
620b410 to
2afa4f1
Compare
shanechesnutt-ft
force-pushed
the
sc/LG-12532
branch
from
2afa4f1 to
d1cc328
Compare
changelog: Internal, Automated Testing, Add 50/50 state integration tests for the state_id step in the ID-IPP/EIPP flow in preperation for removing FSM code.
shanechesnutt-ft
force-pushed
the
sc/LG-12532
branch
from
d1cc328 to
3fb0c18
Compare
🎫 Ticket
LG-12532
🛠 Summary of changes
Added integration tests for covering 50/50 state for the state ID page FSM and Controller.
Added integration tests for the state ID page controller.