-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-14175: Expire EIPP enrollments in job #11085
Conversation
def request_proofing_results(_enrollment) | ||
JSON.parse(Fixtures.request_passed_proofing_results_response) | ||
def request_proofing_results(enrollment) | ||
if enrollment.days_to_due_date.negative? && enrollment.enhanced_ipp? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this to support manual testing. Feedback is welcome! Making the manual testing plan took me longer than anticipated.
@@ -1600,6 +1600,57 @@ | |||
enhanced_ipp_enrollment: true, | |||
) | |||
end | |||
|
|||
context 'when an enrollment expires' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are looking good! 👍🏻
I dug into this more. David showed the message in AWS. That is the response message we get from USPS. I confirmed you are correct, no change to expire EIPP enrollments is needed. I actually received an email today that "The deadline to verify your identity in person has passed". I compared the email address I used and found the enrollment. It was for EIPP. The enrollment was created 7 days ago- so yes, EIPP enrollments are getting expired (currently in staging). I looked at another recently expired email and found the same outcome. The message is the same and EIPP enrollments are being expired in the job in staging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me I will run the test plan and approve tomorrow
@@ -83,8 +83,12 @@ def self.request_passed_proofing_secondary_id_type_results_response_ial_2 | |||
) | |||
end | |||
|
|||
def self.request_expired_proofing_results_response | |||
load_response_fixture('request_expired_proofing_results_response.json') | |||
def self.request_expired_enhanced_ipp_results_response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed- no more instances of request_expired_proofing_results_response
found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through the test plan and everything looks good to me!
🎫 Ticket
LG-14175: Expire EIPP Enrollments in the Job
Related to the first AC in the ticket, here is the slack conversation where David and I discussed that the error message for expired ID-IPP enrollments and for expired EIPP enrollments have the same message formats.
🛠 Summary of changes
📜 Testing Plan
e = InPersonEnrollment.last
Run the below in rails console
Email: