Hide collapsed Accordion component content while JavaScript loads #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This enhances accordion styles to appear hidden while JavaScript is loaded if expected to be collapsed once JavaScript finishes loading, avoiding the appearance of flashing content.
This backports changes added to the brochure site in GSA-TTS/identity-site#1224
It also incorporates a number of improvements:
:not([aria-expanded='true'])
instead of[aria-expanded='false']
to support expected behavior where thearia-expanded
attribute is not explicitly specifiedusa-accordion__container
container element which is not standard to USWDS and would make the JavaScript hiding behavior ineffectivedata-test
attributearia-expanded="false"
src/js/init.ts
to remove unnecessary curly braces on function body, syncing with upstream USWDS - Core: Shrink size of uswds-init.js uswds/uswds#5819📜 Testing Plan
npm start