Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix direct imports to prose styles #415

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix direct imports to prose styles #415

merged 1 commit into from
Mar 4, 2024

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Mar 1, 2024

🛠 Summary of changes

Regression of #390

Fixes an issue where code directly importing usa-prose would fail due to missing _overrides.scss file removed in #390.

Exception [Error]: Error: Can't find stylesheet to import.
  ╷
2 │ @forward './overrides';
  │ ^^^^^^^^^^^^^^^^^^^^^^

The project's current build pipeline would only catch errors occurring in a full build. TBD I need to more fully understand how this doesn't cause a failure within this project, but the short of it seems to be that this file isn't being loaded.

Because we no longer customize the component as of #390, we don't need these files, since the design system is already set up to allow "pass through" to USWDS for uncustomized components.

📜 Testing Plan

I reproduced the issue on main by testing in identity-idp.

In identity-idp:

  1. Change @18f/identity-design-system dependency in package.json to point to file:../identity-design-system
  2. rm -rf node_modules
  3. yarn
  4. yarn buld:css

Before: Fails with error mentioned above
After: Succeeds

@aduth
Copy link
Contributor Author

aduth commented Mar 4, 2024

Visual regression is expected since removal of overrides file causes "View Login.gov SCSS on GitHub" link to be removed from internal documentation.

image

@aduth aduth merged commit ddce1cd into main Mar 4, 2024
4 of 5 checks passed
@aduth aduth deleted the aduth-prose-import-fix branch March 4, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants