Fix direct imports to prose styles #415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Regression of #390
Fixes an issue where code directly importing
usa-prose
would fail due to missing_overrides.scss
file removed in #390.The project's current build pipeline would only catch errors occurring in a full build. TBD I need to more fully understand how this doesn't cause a failure within this project, but the short of it seems to be that this file isn't being loaded.
Because we no longer customize the component as of #390, we don't need these files, since the design system is already set up to allow "pass through" to USWDS for uncustomized components.
📜 Testing Plan
I reproduced the issue on
main
by testing inidentity-idp
.In
identity-idp
:@18f/identity-design-system
dependency inpackage.json
to point tofile:../identity-design-system
rm -rf node_modules
yarn
yarn buld:css
Before: Fails with error mentioned above
After: Succeeds