Align JavaScript component names with USWDS #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
commented
Mar 1, 2024
Comment on lines
+15
to
+18
| const [, exports] = /** @type {RegExpMatchArray} */ ( | ||
| uswdsComponentsIndex.match(/module\.exports = \{([\s\S]+)\};/) | ||
| ); | ||
| const uswdsComponentKeys = Array.from(exports.matchAll(/(?:\s+([a-zA-Z]+)),/g)) |
There was a problem hiding this comment.
I considered pulling in a library like cjs-module-lexer for this, though we already have some regular expressions above for parsing the ESM from this project.
zachmargolis
approved these changes
Mar 1, 2024
Co-authored-by: Zach Margolis <[email protected]>
|
Sad thing is I discovered this is the inverse of a breaking change we previously implemented in 7.0.0 🙈
Hopefully this'll stick. I don't love that the names are inconsistent with package directory in USWDS (which is where the names |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates JavaScript components to ensure that their names match those exported by USWDS. This is an inconsistency within USWDS itself between its package directory names and the corresponding exported JavaScript component name.
Why?
📜 Testing Plan
Verify the modified test passes: