Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

Role validations #116

Merged
merged 8 commits into from
Jul 11, 2021
Merged

Role validations #116

merged 8 commits into from
Jul 11, 2021

Conversation

GaryGapinski
Copy link
Collaborator

This request addresses issue #51 as well as other role-related constraints (the latter lack a specific issue).

@GaryGapinski GaryGapinski requested review from danielnaab and ohsh6o July 7, 2021 17:50
@GaryGapinski GaryGapinski self-assigned this Jul 7, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@GaryGapinski
Copy link
Collaborator Author

GaryGapinski commented Jul 8, 2021

This PR includes all role-related items other than <component> and <inventory-item> <responsible-party> and privacy PoC (all of which are separately handled).

Covers the following sections in DRAFT Guide to OSCAL-based FedRAMP System Security Plans: §4.6 through 4.11 and §4.18.

§4.20 (System Interconnections and Authorized Connections) has not yet been made a task.

@GaryGapinski GaryGapinski marked this pull request as ready for review July 8, 2021 07:36
Copy link

@ohsh6o ohsh6o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B: I am not sure how this works. I see a lot of important supporting work in this PR, but not where it trickles down into responsible-roles. Is that correct? From SSP Guide, Section 5.2, page 36.

   <metadata>
      <role id="admin-unix">
         <title>Unix Administrator</title>
      </role>
   </metadata>

  <!-- Fragment: -->
   <system-implementation>
      <user uuid="uuid-value">
         <role-id>admin-unix</role-id>
      </user>
   </system-implementation >

   <!-- system-implementation -->
   <control-implementation>
      <implemented-requirement uuid="uuid-value" control-id="ac-2">
         <!-- cut -->
         <responsible-role role-id="admin-unix" />
         <set-parameter param-id="ac-1_prm_a">
            <value>System Manager, System Architect, ISSO</value>
         </set-parameter >
         <!-- cut -->
   </control-implementation>

resources/validations/src/ssp.sch Outdated Show resolved Hide resolved
resources/validations/test/ssp.xspec Show resolved Hide resolved
@github-actions

This comment has been minimized.

danielnaab pushed a commit that referenced this pull request Jul 8, 2021
* Fix AC-1 response points misalignment in baselines.

* Update SSP to match changes in baselines.
@github-actions

This comment has been minimized.

Copy link

@ohsh6o ohsh6o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaryGapinski GaryGapinski merged commit 284db78 into master Jul 11, 2021
@GaryGapinski GaryGapinski deleted the role-validations branch July 11, 2021 18:53
@github-actions
Copy link

XSpec Test Results

    1 files  ±0    11 suites  ±0   0s ⏱️ ±0s
354 tests ±0  263 ✔️ ±0  91 💤 ±0  0 ❌ ±0 
356 runs  ±0  263 ✔️ ±0  93 💤 ±0  0 ❌ ±0 

Results for commit 284db78. ± Comparison against base commit 284db78.

@GaryGapinski GaryGapinski mentioned this pull request Jul 11, 2021
17 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants