Feature/control bounce #2
Conversation
Number of frames during with the player pressed the spacebar during the 'bouncing phase' and compared to the total number of frame during this phase.
|
There's something weird with the distance I get when I play. They are statistically strange. Here is the log of the frame difference between the bounce and the input: |
|
OK i fixed it, the input being not debounced, it was being registered again after the bounce resolution. |
src/js/game/states/play.js
Outdated
| makeSplash(game, disc); | ||
| this.bouncer.bounce(); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Why removing them from the callback ?
Is there any benefits in terms of speed / precision ?
There was a problem hiding this comment.
well the callback is synchronous, so yeah, it allows to do branch on collide = false too
| // The disc was too slow and killed | ||
| if (!disc.alive) { | ||
| // Reset the game later | ||
| setTimeout(() => { |
There was a problem hiding this comment.
wasn't the restartTimeout solving the issue of the restart() being triggered multiple times?
There was a problem hiding this comment.
It is, but I find this cleaner, and it does not use any additional reference
KtorZ
force-pushed
the
feature/control-bounce
branch
from
ebc9dcf to
83cd45a
Compare
No description provided.