chore: caches node modules in GitHub Actions workflow #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds logic for caching the contents of the node_modules directory which speeds up workflow runs as long as the package.json file doesn't change (if the lock file is committed, it should be part of the caching key instead of the package.json file). Adds pull requests as workflow triggers so people's contributions have tests running for them (for first-time contributors, a project maintainer must approve workflows to run, see https://github.blog/changelog/2021-04-22-github-actions-maintainers-must-approve-first-time-contributor-workflow-runs/).
|
Comment: Interestingly, me opening this PR from a fork is already enough to trigger the GitHub workflow on the PR itself. I assume I'm allowed to do that because I'm a contributor? It would be good to consider the current settings for who is allowed to trigger workflows and specifically how changed workflows can be run on PRs from forks. Ideally, PRs from forks can't trigger workflow runs without explicit approval. |
|
Appreciate you looking out! Gonna roll with this one! Let me know if you think I should make additional changes here! |
kleinfreund
deleted the
chore/cache-dependencies-in-github-actions-workflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds logic for caching the contents of the node_modules directory which speeds up workflow runs as long as the package.json file doesn't change (if the lock file is committed, it should be used to generate the caching key instead of the package.json file).
Adds pull requests as workflow triggers so people's contributions have tests running for them (for first-time contributors, a project maintainer must approve workflows to run, see https://github.blog/changelog/2021-04-22-github-actions-maintainers-must-approve-first-time-contributor-workflow-runs/; perhaps it's also possible to configure a repository so that this kind of approval is always required for branches on forks (origin repository branches would be fine because you would need push access anyway)).
Notes
YARN_GPGisn't needed? This seems like a leftover from setting this up.