Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GitHub workflows broken due to outdated versions / OS #255

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

agibson-godaddy
Copy link
Contributor

@agibson-godaddy agibson-godaddy commented Mar 6, 2025

Summary

Updates the versions used for various actions to address:

Error: This request has been automatically failed because it uses a deprecated version of actions/cache: 937d24475381cd9c75ae6db12cb4e79714b926ed. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

Also removes deprecated usage of ubuntu-20.04 -- see actions/runner-images#11101

Also updates the phpstan config to address an unrelated failure. See https://github.com/10up/wp_mock/pull/255/files#r1983301587

Details

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
  • I have added tests to cover changes introduced by this pull request
  • All new and existing tests pass

Testing

  • Code review
  • Checks pass / GH actions run successfully

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

@@ -3,6 +3,7 @@ includes:
parameters:
level: max
reportUnmatchedIgnoredErrors: false
treatPhpDocTypesAsCertain: false
Copy link
Contributor Author

@agibson-godaddy agibson-godaddy Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change to address this error:

image

Seems like a good idea anyway. (it was throwing the error because a docblock typed it as a string, but that doesn't actually enforce the type in reality, which is why I think the config change makes sense)

@agibson-godaddy agibson-godaddy changed the title Fix: GitHub workflows Fix: GitHub workflows broken due to outdated versions / OS Mar 6, 2025
@agibson-godaddy agibson-godaddy marked this pull request as ready for review March 6, 2025 12:53
@agibson-godaddy agibson-godaddy self-assigned this Mar 6, 2025
Copy link
Contributor

@ajaynes-godaddy ajaynes-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajaynes-godaddy ajaynes-godaddy merged commit bdbb090 into trunk Mar 6, 2025
8 checks passed
@ajaynes-godaddy ajaynes-godaddy deleted the chore/fix-gh-actions branch March 6, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants