-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setInaccessiblePropertyValue helper method and update docs #223
Merged
nmolham-godaddy
merged 8 commits into
trunk
from
chore/add-set-inaccessible-property-value-helper-method
Jul 6, 2023
Merged
Add setInaccessiblePropertyValue helper method and update docs #223
nmolham-godaddy
merged 8 commits into
trunk
from
chore/add-set-inaccessible-property-value-helper-method
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LVGTM, just added few suggestions to add PHP documentation links, it is not a blocker, I just think it would be a good reference
Co-authored-by: Nabeel Molham <[email protected]>
Co-authored-by: Nabeel Molham <[email protected]>
Co-authored-by: Nabeel Molham <[email protected]>
thanks for the suggestiosn @nmolham-godaddy - I applied those changes with references to PHP.net docs |
nmolham-godaddy
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While adding #220 I forgot one method (for @10up/godaddy-wp_mock these are basically the same as in MWC Tests, and with the addition of this PR we can drop them -- figured these are generally helpful and could be part of WP_Mock directly).
This PR also updates the docs related to
AccessInaccessibleClassMembersTrait
.Fixes an unrelated flaky test.
Contributor checklist
Testing
Reviewer checklist