Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setInaccessiblePropertyValue helper method and update docs #223

Merged

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Jul 6, 2023

Summary

While adding #220 I forgot one method (for @10up/godaddy-wp_mock these are basically the same as in MWC Tests, and with the addition of this PR we can drop them -- figured these are generally helpful and could be part of WP_Mock directly).

This PR also updates the docs related to AccessInaccessibleClassMembersTrait.

Fixes an unrelated flaky test.

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
  • I have added tests to cover changes introduced by this pull request
  • All new and existing tests pass

Testing

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

@unfulvio-godaddy unfulvio-godaddy added Enhancement New feature proposal or pull request Documentation Updates to documentation labels Jul 6, 2023
@unfulvio-godaddy unfulvio-godaddy added this to the v1.0.0 milestone Jul 6, 2023
@unfulvio-godaddy unfulvio-godaddy self-assigned this Jul 6, 2023
@unfulvio-godaddy unfulvio-godaddy requested a review from a team July 6, 2023 03:29
@coveralls
Copy link

coveralls commented Jul 6, 2023

Coverage Status

coverage: 65.6% (+0.05%) from 65.554% when pulling 77d3998 on chore/add-set-inaccessible-property-value-helper-method into c176fd8 on trunk.

@nmolham-godaddy nmolham-godaddy self-requested a review July 6, 2023 04:38
Copy link
Contributor

@nmolham-godaddy nmolham-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM, just added few suggestions to add PHP documentation links, it is not a blocker, I just think it would be a good reference

@unfulvio-godaddy unfulvio-godaddy requested review from nmolham-godaddy and a team July 6, 2023 04:45
@unfulvio-godaddy
Copy link
Member Author

thanks for the suggestiosn @nmolham-godaddy - I applied those changes with references to PHP.net docs

@nmolham-godaddy nmolham-godaddy merged commit 93b6fcd into trunk Jul 6, 2023
@nmolham-godaddy nmolham-godaddy deleted the chore/add-set-inaccessible-property-value-helper-method branch July 6, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Updates to documentation Enhancement New feature proposal or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants