Fix typos #839
Fix typos #839
Conversation
jeffpaul
requested review from
iamdharmesh
and removed request for
a team,
dkotter and
jeffpaul
| @@ -458,7 +458,7 @@ public function render_meta_box( \WP_Post $post ) { | |||
| </label> | |||
| </p> | |||
|
|
|||
| <div class="classifai-clasify-post-wrapper" style="display: none;"> | |||
| <div class="classifai-classify-post-wrapper" style="display: none;"> | |||
There was a problem hiding this comment.
While this is a typo, because this is used as a class name, we'll need to decide if we want to leave this as-is, as others may be relying on this class for styling purposes and updating this will break things for them. Not overly concerned but something for us to consider
There was a problem hiding this comment.
Just adding additional details here that this is used in the classic editor only.
| @@ -513,7 +513,7 @@ document.addEventListener( 'DOMContentLoaded', function () { | |||
| if ( classifaiNLUCheckbox ) { | |||
| classifaiNLUCheckbox.addEventListener( 'change', function () { | |||
| const classifyButton = document.querySelector( | |||
| '.classifai-clasify-post-wrapper' | |||
| '.classifai-classify-post-wrapper' | |||
There was a problem hiding this comment.
If we decide we don't want to change this class name (mentioned in another comment) we'll want to revert this change as well
There was a problem hiding this comment.
Thanks for all the help here @szepeviktor. LGTM. I have added GitHub Action workflow for the spelling check on PR.
@dkotter sending this to you for another review. Thanks.
|
Glad to contribute. |
Description of the Change
Introduce https://github.com/crate-ci/typos to ClassifAI.