Save autoshare meta from post form before publishing tweet

[johnwatkins0]

Description of the Change

This resolves a bug brought up by @rickalee in #80. Autoshare form data is saved in save_post while the tweet action runs on transition_post_status. transition_post_status runs earlier than save_post, so the bug happened in the case where:

1. The post is switching from from a non-publish status to publish
2. AND the autoshare status is switching from enabled to disabled.

In this case, the enabled status has not been saved before the tweet function runs, so the post is tweeted.

This update causes the form data to be processed before trying to tweet.

Alternate Designs

I'm wanting to refactor large parts of this plugin, but I'm holding for now and will aim to submit issues outlining the specific technical debt I'm seeing.

Benefits

Tweets won't be inadvertently published during the specific scenario outlined above.

Possible Drawbacks

Verification Process

1. Create a new post
2. Leave 'Tweet this Post' checked
3. Save Draft
4. Uncheck 'Tweet this Post'
5. Save Draft/Publish
6. Post should not be tweeted

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Applicable Issues

Resolves #80

Changelog Entry

Fix a bug that caused posts to be inadvertently tweeted when switching from draft to publish

[rickalee]

Confirmed all looks good on our side. Packaging up for client bugfix and will follow up if they catch anything.

[rickalee]

No reported issues after pushing to client site as hotfix and confirmed Twitter timeline looks good. Thanks @johnwatkins0 . I think we can safely add to next release.

[jeffpaul]

@johnwatkins0 are there any tests that we can add to cover this to avoid a regression back to this behavior later?

[johnwatkins0]

@jeffpaul Yes, we could definitely increase test coverage. I'll look into adding a unit test for this particular PR later. I'd also like to try #19 to see how well WPAcceptance can cover this sort of thing, but that should probably be a separate task because it will involve setting up acceptance tests and probably adding more than just this one.

[jeffpaul]

@rickalee @johnwatkins0 did either of you want/need to ship a v1.0.2 for this or hold and include in a larger v1.1.0 later?

[johnwatkins0]

Broke this out into a function (see below) for easier testing.

[johnwatkins0]

I added some tests and also did some cleanup around meta saving. Sorry about the growing diff, @dinhtungdu .

I'm aiming to use my extra time over the next few days to set up WP Acceptance ahead of a 1.1.0 release, but I'll work on that in a separate PR.

[dinhtungdu]

Worked great in my tests! 🎉