Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run build:externals script during release #77

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Run build:externals script during release #77

merged 2 commits into from
Feb 3, 2020

Conversation

johnwatkins0
Copy link
Member

Description of the Change

The .org build script needs to build the externals (i.e., apiFetch for pre-WP 5.0 environments).

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@jeffpaul jeffpaul self-requested a review February 3, 2020 22:23
@jeffpaul jeffpaul added this to the 1.1.0 milestone Feb 3, 2020
jeffpaul
jeffpaul approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @johnwatkins0!

@johnwatkins0 johnwatkins0 merged commit 798c417 into develop Feb 3, 2020
@johnwatkins0 johnwatkins0 deleted the fix/deploy-externals branch February 3, 2020 22:26
@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.0.2 Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

Assignees

@johnwatkins0 johnwatkins0

Labels
None yet
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@johnwatkins0 @jeffpaul