-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace custom build process with WP-Scripts #282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamdharmesh The Pull request is looking good to me. I left a minor suggestion and a new issue which is not a blocker.
Let me know if you have any questions.
Additional issues:
- The Twitter icon is middle aligned in the column, which looks odd with other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of notes inline.
@ravinderk @peterwilsoncc looking for updated review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ravinderk I have addressed PR feedback. Also, E2E tests are failing as we use |
Description of the Change
PR replaces current custom build process with WP-Scripts also removes some legacy files which no longer needed
Closes #193
How to test the Change
npm install
npm run build
Changelog Entry
Credits
Props @iamdharmesh @peterwilsoncc
Checklist: