Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed connected Twitter accounts visibility in the classic editor. #269

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

iamdharmesh
Copy link
Member

Description of the Change

During release-ready testing, I came across this minor issue of Twitter account visibility in the classic editor. when we disable AutoShare, connected accounts get hidden but on page refresh, it becomes visible again.

Screenshot 2023-08-18 at 11 44 50 AM

This PR fixes this issue and also adds a hidden field for identifying the request from the classic editor.

How to test the Change

  1. Create a post with draft status
  2. Disable Autoshare by unchecking the "Tweet this post" checkbox
  3. Save the post (draft) and verify tweet accounts are not visible.
  4. Refresh the page and verify that tweet accounts are not visible.
  5. Enable Autoshare by checking the "Tweet this post" checkbox
  6. Save the post (draft) and verify tweet accounts are visible.
  7. Refresh the page and verify that tweet accounts are visible.

Changelog Entry

Fixed - Connected Twitter accounts visibility in the classic editor.

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions github-actions bot added the needs:code-review This requires code review. label Aug 18, 2023
@iamdharmesh iamdharmesh requested a review from Sidsector9 August 18, 2023 06:20
@iamdharmesh iamdharmesh added this to the 2.1.1 milestone Aug 18, 2023
@iamdharmesh iamdharmesh merged commit f8e6380 into develop Aug 18, 2023
@iamdharmesh iamdharmesh deleted the fix/classic-editor branch August 18, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants