Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the saved Twitter keys obfuscated in the UI #245

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

bmarshall511
Copy link
Contributor

Description of the Change

Made the saved Twitter keys obfuscated in the UI, see #240

Closes #240

How to test the Change

  1. Go to /wp-admin/options-general.php?page=autoshare-for-twitter
  2. Save your Twitter credentials
  3. Toggle open the 'Open connection settings' after save
  4. Keys should be obfuscated

Changelog Entry

Added - Obfuscating saved Twitter keys

Credits

Props @bmarshall511

Checklist:

@bmarshall511 bmarshall511 added this to the 2.1.0 milestone Jun 20, 2023
@bmarshall511 bmarshall511 self-assigned this Jun 20, 2023
@github-actions github-actions bot added the needs:code-review This requires code review. label Jun 20, 2023
@iamdharmesh
Copy link
Member

Hi @bmarshall511,

Thank you for submitting the PR. I've reviewed the code, and it looks great! and It effectively resolves issue #240. However, I want to discuss the approach we have taken here, It seems a bit overcomplicated to me. I was wondering if you have considered converting the text fields to password fields instead. This alternative approach could simplify things here. I'd love to hear your thoughts on this.

Thanks

@bmarshall511
Copy link
Contributor Author

Hey @iamdharmesh 👋

I did consider the option of converting the text fields to password fields, but I ultimately decided to take the current approach because the issue specifically mentioned going in that direction.

However, I completely agree with you that using password fields would be a much simpler solution. It definitely has its advantages. On the other hand, I can also see the value in allowing users to see the last digits of the keys, especially for those who manage multiple projects like myself. It's like the online bank account approach, where you can quickly verify the right numbers for the right projects.

From a user's perspective, password fields can sometimes be a bit tricky to use in this particular use case. So, I thought it would be more user-friendly to have the last digits visible. But I'm definitely open to exploring the password field option further if that's what you prefer.

Let me know your thoughts!

Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing your thoughts @bmarshall511.

I can also see the value in allowing users to see the last digits of the keys, especially for those who manage multiple projects like myself. It's like the online bank account approach, where you can quickly verify the right numbers for the right projects.

I agree on this.

Thanks for your work here.

@jeffpaul jeffpaul merged commit b9d3feb into develop Jun 23, 2023
@jeffpaul jeffpaul deleted the feat/secure-values-ben branch June 23, 2023 19:10
@jeffpaul jeffpaul removed the needs:code-review This requires code review. label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Keys are stored in plain text in the configuration screen
3 participants