Add support for multiple Twitter Accounts #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6b331dd.
iamdharmesh
changed the title
jeffpaul
requested review from
a team and
Sidsector9
and removed request for
a team and
jeffpaul
Sidsector9
requested changes
Jun 27, 2023
There was a problem hiding this comment.
@iamdharmesh thanks for this amazing work! I've requested for few changes, let me know if you'd like to discuss it over a call.
|
Thanks a lot for the review and feedback @Sidsector9. I have addressed all feedback in 5a24c7d. Could you please help to re-review and confirm once? Thanks. |
Sidsector9
requested changes
Jun 29, 2023
includes/admin/post-transition.php
Outdated
| @@ -92,7 +94,7 @@ function( $post ) { | |||
| * @param int $post_id The current post ID. | |||
| * @param bool $force Publish tweet regardless of autoshare enabled or disabled on post. | |||
| * | |||
| * @return object | |||
| * @return bool|void | |||
There was a problem hiding this comment.
@iamdharmesh I think we should strictly set it to bool.
In case this function returns void which will evaluate to null, that null will be set here:
In JS, we strictly check it against false here:
What do you think?
There was a problem hiding this comment.
Yeah, not related to this PR but important enough to fix it here. Updated. Thanks
Sidsector9
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Added support for connecting multiple Twitter Accounts and sending tweets to those accounts.
PR also, Fixes E2E tests failure by skip Twitter API calls.
Block Editor:
Classic Editor:
Closes #230
Closes #237
How to test the Change
Backward compatibility
New features
Changelog Entry
Credits
Props @iamdharmesh @jeffpaul
Checklist: