Migrate to Twitter API v2 #229

iamdharmesh · 2023-04-28T10:50:44Z

Description of the Change

PR migrates the current Twitter API implementation to use API v2. Majorly PR has made the below changes

Migrated to Twitter API v2
Add migrate to v2 notice for only existing users
Update app setup steps to the latest process
Added learn more link to error message for old credentials user

Closes #173

How to test the Change

Follow the steps mentioned on the Autoshare for Twitter Settings admin page and set up the Twitter app. You should be able to set up the plugin without struggle. After saving the plugin setting with the Twitter app details, you should be able to tweet from WordPress from the post edit page.

Make sure the plugin works fine with Twitter API v2
Verify plugin shows notice about migrating to v2 to existing users
Error message to existing v1.1 API users while tweet post.

Changelog Entry

Added - Support for Twitter API v2.
Changed - Update plugin settings and guidelines to set up a Twitter app.

Credits

Props @iamdharmesh, @qasumitbagthariya, @ravinderk, @jeffpaul.

Noticeable changes

Add PHP dependency to 7.4 in composer.json

Checklist:

I agree to follow this project's Code of Conduct.
I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.

ravinderk · 2023-05-01T14:22:26Z

@iamdharmesh For some reason, E2E tests are failing. This pull request does not change anything related to UI/UX. Do you know if these tests are falling correctly?

This reverts commit 613513f.

This reverts commit 7d47e95.

iamdharmesh · 2023-05-11T07:03:11Z

@ravinderk I have reverted app setup instructions as we discussed internally on call, Also tests seems failing due to credentials currently setup in repo secret is not migrated to Twitter API V2 yet.

Thanks

jeffpaul · 2023-05-11T15:19:52Z

@iamdharmesh I added the *_V2 repo secrets and then updated the cypress workflow, but still seems to have some failures. Could you please check those?

jeffpaul · 2023-05-11T15:26:28Z

Let's update the sidebar error from:

Failed to tweet: Error: . <Twitter error here>

to:

Failed to tweet; error: <Twitter error here>

...also, if the Twitter error is the "When authenticating requests to the Twitter API v2 endpoints, you must use keys and tokens from a Twitter developer App that is attached to a Project. You can create a project via the developer portal." (hopefully there's an error code we can target in case they change that copy) then let's please add after the Twitter error message "Learn more here." and link to https://developer.twitter.com/en/docs/twitter-api/migrate/ready-to-migrate.

...which means in this case that would be like:

Failed to tweet; error: <Twitter error here> Learn more here.

jeffpaul · 2023-05-11T16:16:57Z

On the Settings page, update all references existing to match spelling/case of:

API Key
API Key Secret
Access Token
Access Token Secret

...this way we match the exact same spelling/case/wording used on https://developer.twitter.com to avoid user confusion on configuring the plugin.

jeffpaul · 2023-05-11T16:30:04Z

Let's update the admin notice to:
Autoshare for Twitter now utilizes the Twitter v2 API. If you have not already done so, please migrate your app to Twitter v2 API to continue using Autoshare for Twitter. Learn more about migrating here.

jeffpaul · 2023-05-11T16:30:46Z

@iamdharmesh the above couple updates should bring this PR to a good point for final review/merge... thanks!

…to migrate-v2

iamdharmesh · 2023-05-12T15:11:06Z

Failed to tweet: Error: . <Twitter error here>

@jeffpaul Currently we are also showing an error code in this message. for eg: Error: 429. Too Many Requests. (dot there looks extra due to no error code) So, should we keep it showing the error code OR it is no longer needed?

jeffpaul · 2023-05-12T15:33:46Z

If there's no code then let's not display the "Error: ." bit, if there is a code then we can keep that wrapping text.

iamdharmesh · 2023-05-15T10:23:15Z

@iamdharmesh I added the *_V2 repo secrets and then updated the cypress workflow, but still seems to have some failures. Could you please check those?

It failed due to the API limit was exceeded for 24 hours.

Sidsector9

Thanks for this PR! I've requested some minor changes, after that it's good to go 🎉

Sidsector9 · 2023-05-16T07:22:37Z

autoshare-for-twitter.php

+	__FILE__,
+	function () {
+		// Don't need to show migration notice to new users.
+		update_option( 'migrate_to_twitter_v2_api_notice_dismissed', true );


A nitpick here - will be good to prefix the option with autoshare_

Sidsector9 · 2023-05-16T07:25:37Z

includes/admin/post-meta.php

@@ -317,7 +317,7 @@ function get_tweet_status_message( $post ) {

 			case 'error':
 				$response_array[] = [
-					'message' => __( 'Failed to tweet: ', 'autoshare-for-twitter' ) . $tweet_meta['message'],
+					'message' => __( 'Failed to tweet; ', 'autoshare-for-twitter' ) . $tweet_meta['message'],


Is this intentional? Colon : would be appropriate here.

@Sidsector9 it is updated as per the request here #229 (comment)

includes/admin/post-meta.php

src/js/AutoshareForTwitterPostStatusInfo.js

ravinderk

@iamdharmesh I left a few questions.

iamdharmesh added 2 commits February 7, 2023 19:27

Initial Migration to Twitter API v2

03fd633

Add setting for use Twitter API v2

021afd8

iamdharmesh self-assigned this Apr 28, 2023

iamdharmesh added this to the 1.4.0 milestone Apr 28, 2023

iamdharmesh added 3 commits April 28, 2023 16:21

Merge branch 'develop' into migrate-v2

9b958b8

Make Twitter API V2 default and remove option for enable it.

8b1d631

Update onboarding instructions.

2aaeb5b

iamdharmesh assigned ravinderk Apr 28, 2023

ravinderk added 6 commits May 1, 2023 12:11

dev: set php dependency to 7.4 in composer.json

e55de1e

chore: resolve merge conflicts

85100f0

doc: set correct var type to class property

af580a3

doc: set correct param type

d9694c2

doc: document twiiter proand and app setup steps

7d47e95

doc: document twiiter proand and app setup steps

613513f

jeffpaul mentioned this pull request May 9, 2023

Add support for linking multiple Twitter accounts #230

Closed

3 tasks

iamdharmesh added 4 commits May 10, 2023 20:29

Revert "doc: document twiiter proand and app setup steps"

5acb44b

This reverts commit 613513f.

Revert "doc: document twiiter proand and app setup steps"

5c852a2

This reverts commit 7d47e95.

Update wp utils lib.

8754e6c

Run "npm audit fix"

b02a69b

Update to V2 repo secrets

8f1e36c

jeffpaul mentioned this pull request May 11, 2023

Release version 2.0.0 #233

Closed

17 tasks

iamdharmesh added 2 commits May 12, 2023 20:06

Update twitter credentials wordings.

4e87e26

Merge branch 'migrate-v2' of github.com:10up/autoshare-for-twitter in…

3cc5bcb

…to migrate-v2

Add migrate to v2 notice for existing users.

cfcf79d

Add migrate error message to error message.

cbcfab2

iamdharmesh changed the title ~~[WIP] Migrate to Twitter API v2~~ Migrate to Twitter API v2 May 15, 2023

PHPCS fixes.

49bb523

iamdharmesh marked this pull request as ready for review May 15, 2023 10:24

iamdharmesh requested a review from jeffpaul as a code owner May 15, 2023 10:24

iamdharmesh requested a review from a team May 15, 2023 10:24

github-actions bot added the needs:code-review This requires code review. label May 15, 2023

jeffpaul requested review from a team and removed request for a team May 15, 2023 15:53

Sidsector9 requested changes May 16, 2023

View reviewed changes

ravinderk reviewed May 16, 2023

View reviewed changes

includes/admin/post-meta.php Show resolved Hide resolved

ravinderk reviewed May 16, 2023

View reviewed changes

src/js/AutoshareForTwitterPostStatusInfo.js Outdated Show resolved Hide resolved

ravinderk reviewed May 16, 2023

View reviewed changes

iamdharmesh added 2 commits May 16, 2023 15:07

Add autoshare prefix in notice dismiss option key.

8fe6b40

Update error message compare message to ?.includes

7494185

iamdharmesh requested review from Sidsector9 and ravinderk May 16, 2023 10:07

Sidsector9 approved these changes May 16, 2023

View reviewed changes

Merge branch 'develop' into migrate-v2

7d1db9c

iamdharmesh merged commit 9b159dc into develop May 16, 2023

iamdharmesh deleted the migrate-v2 branch May 16, 2023 10:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to Twitter API v2 #229

Migrate to Twitter API v2 #229

iamdharmesh commented Apr 28, 2023 •

edited

Loading

ravinderk commented May 1, 2023

iamdharmesh commented May 11, 2023

jeffpaul commented May 11, 2023

jeffpaul commented May 11, 2023

jeffpaul commented May 11, 2023

jeffpaul commented May 11, 2023

jeffpaul commented May 11, 2023

iamdharmesh commented May 12, 2023

jeffpaul commented May 12, 2023

iamdharmesh commented May 15, 2023

Sidsector9 left a comment

Sidsector9 May 16, 2023

Sidsector9 May 16, 2023

iamdharmesh May 16, 2023

ravinderk left a comment

Migrate to Twitter API v2 #229

Migrate to Twitter API v2 #229

Conversation

iamdharmesh commented Apr 28, 2023 • edited Loading

Description of the Change

How to test the Change

Changelog Entry

Credits

Noticeable changes

Checklist:

ravinderk commented May 1, 2023

iamdharmesh commented May 11, 2023

jeffpaul commented May 11, 2023

jeffpaul commented May 11, 2023

jeffpaul commented May 11, 2023

jeffpaul commented May 11, 2023

jeffpaul commented May 11, 2023

iamdharmesh commented May 12, 2023

jeffpaul commented May 12, 2023

iamdharmesh commented May 15, 2023

Sidsector9 left a comment

Choose a reason for hiding this comment

Sidsector9 May 16, 2023

Choose a reason for hiding this comment

Sidsector9 May 16, 2023

Choose a reason for hiding this comment

iamdharmesh May 16, 2023

Choose a reason for hiding this comment

ravinderk left a comment

Choose a reason for hiding this comment

iamdharmesh commented Apr 28, 2023 •

edited

Loading