Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump WordPress "tested up to" version 6.1 #200

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Bump WordPress "tested up to" version 6.1 #200

merged 2 commits into from
Dec 1, 2022

Conversation

iamdharmesh
Copy link
Member

Description of the Change

Performed tests with WordPress core 6.1, Twenty Twenty Three theme

Tests performed:

  • Plugin activate/deactivate on WP6.1
  • Set up the plugin and connected to the Twitter account
  • Created a post and tested the Tweet feature with and without feature image.
  • Verified Twitter post has been created successfully.

Closes #198

How to test the Change

Changelog Entry

Changed - Bump WordPress "tested up to" version 6.1

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh self-assigned this Nov 29, 2022
@github-actions github-actions bot added the needs:code-review This requires code review. label Nov 29, 2022
@iamdharmesh iamdharmesh added this to the 1.3.0 milestone Nov 29, 2022
@iamdharmesh iamdharmesh requested review from a team and peterwilsoncc and removed request for a team November 29, 2022 13:42
@iamdharmesh iamdharmesh modified the milestones: 1.3.0, 1.2.1 Nov 30, 2022
@iamdharmesh iamdharmesh mentioned this pull request Nov 30, 2022
Closed
16 tasks
peterwilsoncc
peterwilsoncc approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tested the following in WP 6.1:

  • saving options (new twitter api data)
  • tweeting from classic and block editors
  • tweeting from classic and block editors with a custom message
  • tweeting with a featured image

All worked as expected.

@peterwilsoncc peterwilsoncc merged commit e44bcb6 into develop Dec 1, 2022
@peterwilsoncc peterwilsoncc deleted the upkeep/198 branch December 1, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwilsoncc peterwilsoncc peterwilsoncc approved these changes

Assignees

@iamdharmesh iamdharmesh

Labels
needs:code-review This requires code review.
Projects
Open Source Practice
Archived in project
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

The plugin hasn't been tested with the latest version of WordPress
2 participants
@iamdharmesh @peterwilsoncc